From 9c75ddd9caedd155af0d892ae1a61a6e04f076fd Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Fri, 7 Aug 2026 16:13:19 +0000
Subject: [PATCH] ci(bench): do not fail benchmarks when Polar Signals setup
 fails

The Parca Agent release download in the Polar Signals setup step is a
network operation that can fail transiently ("socket hang up"), which
currently aborts the whole benchmark job before it runs. Profiling is
supplementary to the benchmark results, and the debuginfo pre-upload step
is already continue-on-error, so let the benchmark proceed without it.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
---
 .github/workflows/develop-bench.yml    | 2 ++
 .github/workflows/pr-bench-runner.yml  | 2 ++
 .github/workflows/sql-bench-matrix.yml | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/.github/workflows/develop-bench.yml b/.github/workflows/develop-bench.yml
index 103583bb2aa..2066d80257c 100644
--- a/.github/workflows/develop-bench.yml
+++ b/.github/workflows/develop-bench.yml
@@ -92,6 +92,8 @@ jobs:
 
       - name: Setup Polar Signals
         uses: polarsignals/gh-actions-ps-profiling@68ae857e375a826606352016e5b90f01a2a7ff7a  # v0.8.1
+        # Profiling is observability only, so a flaky agent download must not fail the benchmark.
+        continue-on-error: true
         with:
           polarsignals_cloud_token: ${{ secrets.POLAR_SIGNALS_API_KEY }}
           labels: "branch=${{ github.ref_name }};gh_run_id=${{ github.run_id }};commit_sha=${{ github.sha }};benchmark=${{ matrix.benchmark.id }}"
diff --git a/.github/workflows/pr-bench-runner.yml b/.github/workflows/pr-bench-runner.yml
index b1b5d8c8799..edaa33aea66 100644
--- a/.github/workflows/pr-bench-runner.yml
+++ b/.github/workflows/pr-bench-runner.yml
@@ -76,6 +76,8 @@ jobs:
       - name: Setup Polar Signals
         if: github.event.pull_request.head.repo.fork == false
         uses: polarsignals/gh-actions-ps-profiling@68ae857e375a826606352016e5b90f01a2a7ff7a  # v0.8.1
+        # Profiling is observability only, so a flaky agent download must not fail the benchmark.
+        continue-on-error: true
         with:
           polarsignals_cloud_token: ${{ secrets.POLAR_SIGNALS_API_KEY }}
           labels: "branch=${{ github.ref_name }};gh_run_id=${{ github.run_id }};commit_sha=${{ github.event.pull_request.head.sha }};benchmark=${{ inputs.benchmark_id }}"
diff --git a/.github/workflows/sql-bench-matrix.yml b/.github/workflows/sql-bench-matrix.yml
index 0db85313641..53f127568d1 100644
--- a/.github/workflows/sql-bench-matrix.yml
+++ b/.github/workflows/sql-bench-matrix.yml
@@ -178,6 +178,8 @@ jobs:
       - name: Setup Polar Signals
         if: inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false
         uses: polarsignals/gh-actions-ps-profiling@68ae857e375a826606352016e5b90f01a2a7ff7a  # v0.8.1
+        # Profiling is observability only, so a flaky agent download must not fail the benchmark.
+        continue-on-error: true
         with:
           polarsignals_cloud_token: ${{ secrets.POLAR_SIGNALS_API_KEY }}
           labels: "branch=${{ github.ref_name }};gh_run_id=${{ github.run_id }};commit_sha=${{ inputs.mode == 'pr' && github.event.pull_request.head.sha || github.sha }};benchmark=${{ matrix.id }}"