make query stringification more comformant to RFC3986 (close #1027)

Author: yyx990803

src/util/query.js

@@ -2,7 +2,17 @@
 
 import { warn } from './warn'
 
-const encode = encodeURIComponent
+const encodeReserveRE = /[!'()*]/g
+const encodeReserveReplacer = c => '%' + c.charCodeAt(0).toString(16)
+const commaRE = /%2C/g
+
+// fixed encodeURIComponent which is more comformant to RFC3986:
+// - escapes [!'()*]
+// - preserve commas
+const encode = str => encodeURIComponent(str)
+  .replace(encodeReserveRE, encodeReserveReplacer)
+  .replace(commaRE, ',')
+
 const decode = decodeURIComponent
 
 export function resolveQuery (

test/unit/specs/navigation-callback.spec.js

@@ -1,6 +1,6 @@
 import Router from '../../../src/index'
 
-fdescribe('Programmatic navigation callbacks', () => {
+describe('Programmatic navigation callbacks', () => {
   let calls = []
   let router, spy1, spy2
 

test/unit/specs/query.spec.js

@@ -19,5 +19,17 @@ describe('Query utils', () => {
         arr: [1, 2]
       })).toBe('?foo=bar&baz=qux&arr=1&arr=2')
     })
+
+    it('should escape reserved chars', () => {
+      expect(stringifyQuery({
+        a: '*()!'
+      })).toBe('?a=%2a%28%29%21')
+    })
+
+    it('should preserve commas', () => {
+      expect(stringifyQuery({
+        list: '1,2,3'
+      })).toBe('?list=1,2,3')
+    })
   })
 })