Merge pull request #115 from oBusk/fix-culori-fail

Don't crash server if culori fails to parse a variable

Author: vunguyentuan

.changeset/full-lions-tease.md

@@ -0,0 +1,6 @@
+---
+"css-variables-language-server": patch
+"vscode-css-variables": patch
+---
+
+Prevent crashing when css variables have unexpected format such as `--font: var(--font-size)/var(--line-height);`

packages/css-variables-language-server/src/CSSVariableManager.ts

@@ -201,7 +201,14 @@ export default class CSSVariableManager {
 
       // If the value was resolved (changed), try to parse it as a color
       if (resolvedValue !== originalValue) {
-        const culoriColor = culori.parse(resolvedValue);
+        let culoriColor: culori.Color;
+
+        try {
+          // Culori will throw on some invalid variables, we should not crash the server
+          culoriColor = culori.parse(resolvedValue);
+        } catch {
+          return;
+        }
 
         if (culoriColor) {
           // Update the color property for this variable

packages/css-variables-language-server/src/tests/fixtures/nested-var-resolution/main.css

@@ -41,4 +41,5 @@
   /* Non-color variables (should not get color property) */
   --spacing: 16px;
   --font-size: 14px;
+  --font: 700 14px/16px 'Helvetica Neue', sans-serif;
 }

packages/css-variables-language-server/src/tests/unit-tests/CSSVariableManager.test.ts

@@ -191,6 +191,9 @@ describe('CSS Variable Manager', () => {
     expect(allVars.get('--font-size').symbol.value).toEqual('14px');
     expect(allVars.get('--font-size').color).toBeUndefined();
 
+    expect(allVars.get('--font').symbol.value).toEqual("700 14px/16px 'Helvetica Neue', sans-serif");
+    expect(allVars.get('--font').color).toBeUndefined();
+
     // Test cross-file resolution
     expect(allVars.get('--child-color-red').symbol.value).toEqual('var(--color-red)');
     expect(allVars.get('--child-color-red').color).toBeDefined();