Skip to content

fix[venom]: fix deploy immutables layout and ctor memory accounting #4786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
harkal wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

fix[venom]: fix deploy immutables layout and ctor memory accounting #4786

harkal wants to merge 18 commits into from

Conversation

@harkal
Copy link
Collaborator

@harkal harkal commented Dec 1, 2025 •
edited
Loading

What I did

How I did it

How to verify it

Commit message

This commit reworks deploy immutables and ctor accounting. It removes
`iload`/`istore` support from venom and `IMMUTABLES` effects to allow for better
optimizations and builds the deploy context in two passes to honor ctor peak 
accurately without resorting to use the peak from the old pipeline.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 1, 2025
View reviewed changes
vyper/venom/context.py
from typing import Iterator, Optional

from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable
from vyper.venom.basicblock import IRAbstractMemLoc, IRBasicBlock, IRLabel, IRVariable

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'IRAbstractMemLoc' may not be defined if module
vyper.venom.basicblock
Loading
is imported before module
vyper.venom.context
Loading
, as the
definition
Loading
of IRAbstractMemLoc occurs after the cyclic
import
Loading
of vyper.venom.context.
vyper/venom/context.py
from typing import Iterator, Optional

from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable
from vyper.venom.basicblock import IRAbstractMemLoc, IRBasicBlock, IRLabel, IRVariable

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'IRBasicBlock' may not be defined if module
vyper.venom.basicblock
Loading
is imported before module
vyper.venom.context
Loading
, as the
definition
Loading
of IRBasicBlock occurs after the cyclic
import
Loading
of vyper.venom.context.
vyper/venom/context.py
from typing import Iterator, Optional

from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable
from vyper.venom.basicblock import IRAbstractMemLoc, IRBasicBlock, IRLabel, IRVariable

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'IRLabel' may not be defined if module
vyper.venom.basicblock
Loading
is imported before module
vyper.venom.context
Loading
, as the
definition
Loading
of IRLabel occurs after the cyclic
import
Loading
of vyper.venom.context.
vyper/venom/context.py
from typing import Iterator, Optional

from vyper.venom.basicblock import IRBasicBlock, IRLabel, IRVariable
from vyper.venom.basicblock import IRAbstractMemLoc, IRBasicBlock, IRLabel, IRVariable

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'IRVariable' may not be defined if module
vyper.venom.basicblock
Loading
is imported before module
vyper.venom.context
Loading
, as the
definition
Loading
of IRVariable occurs after the cyclic
import
Loading
of vyper.venom.context.
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 95.31250% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.29%. Comparing base (647a6e7) to head (670dda8).

Files with missing lines Patch % Lines
vyper/venom/__init__.py 91.11% 1 Missing and 3 partials ⚠️
vyper/venom/passes/concretize_mem_loc.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4786   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         140      140           
  Lines       20273    20334   +61     
  Branches     3553     3562    +9     
=======================================
+ Hits        18913    18970   +57     
- Misses        912      914    +2     
- Partials      448      450    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@harkal