style: apply /style-guide pass to models/tables#2725
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
📚 Mintlify Preview Links📝 Changed (6 total)📄 Pages (6)
🤖 Generated automatically when Mintlify deployment succeeds |
🔗 Link Checker Results✅ All links are valid! No broken links were detected. Checked against: https://wb-21fd5541-style-guide-models-tables-20260604-114339.mintlify.app |
|
Incorrect PR title |
a7fd2ad to
8c4bc36
Compare
Cursor's worktree contagion ended up slurping in other files' style edits; rescoped to models/tables |
There was a problem hiding this comment.
Pull request overview
This PR applies automated style-guide edits across the models/tables documentation pages (primarily prose restructuring, heading/list formatting, and added frontmatter keywords) to improve readability and consistency.
Changes:
- Added
keywordsmetadata and expanded/clarified introductory copy across the tables docs. - Reformatted notes, lists, and section structure for improved scanability.
- Minor wording updates throughout examples and procedural steps.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| models/tables/evaluate-models.mdx | Adds keywords and restructures Weave/Tables evaluation sections and bullets. |
| models/tables/log_tables.mdx | Adds keywords and rewrites intro + logging mode explanations for clarity. |
| models/tables/tables-download.mdx | Adds keywords and rewrites export steps and “Next steps” section. |
| models/tables/tables-gallery.mdx | Adds keywords and reorganizes/rewrites gallery intro and section headings. |
| models/tables/tables-walkthrough.mdx | Adds keywords and rewrites Quickstart framing and step descriptions. |
| models/tables/visualize-tables.mdx | Adds keywords and rewrites comparison/stepper sections and note formatting. |
Comments suppressed due to low confidence (1)
models/tables/evaluate-models.mdx:111
- The
llm_judge_scorerexample usesawait judge_model.predict(...)inside a regulardef, which is invalid Python syntax. The function should be declaredasync defif it awaits.
@weave.op()
def llm_judge_scorer(expected: str, output: str, judge_model) -> dict:
prompt = f"Is this answer correct? Expected: {expected}, Got: {output}"
judgment = await judge_model.predict(prompt)
return {"judge_score": judgment}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- log_tables: fix broken intro anchors (#create-and-log-a-table, #logging-modes)
- visualize-tables: fix #custom-step-key anchor (was #custom-step-keys)
- tables-download: correct API in prose to artifact.add(table, "my_table")
+ artifact.get("my_table"), matching the example code
- tables-walkthrough: drop unfulfilled "query" promise from intro (no query
step in the walkthrough); title retained for external-reference consistency
- evaluate-models: make llm_judge_scorer async def so its await is valid Python
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Review feedback addressed in 7910ed9Thanks for the reviews. All Copilot comments are incorporated:
Re: the suppressed low-confidence comment on PR title — resolved earlier (rescoped to Two related items I left alone (your call)
|
Summary
This PR applies the
/style-guideskill (Google Developer Style Guide + CoreWeave conventions) to documentation undermodels/tables. The run was fully automated; only style-level edits were made.Files edited
models/tables/evaluate-models.mdxmodels/tables/log_tables.mdxmodels/tables/tables-download.mdxmodels/tables/tables-gallery.mdxmodels/tables/tables-walkthrough.mdxmodels/tables/visualize-tables.mdxRecommendations for technical review
Prerequisites
weave,wandb,pandas), Python/runtime version, login (wandb login), and account/project access:evaluate-models.mdx(entity/project access, Models Registry access)log_tables.mdx(W&B account, SDK version, project access)tables-download.mdx(link to artifact basics; notepandasdependency)tables-walkthrough.mdx(labeled as Tutorial / Quickstart but missing prereqs)visualize-tables.mdx(logged W&B Tables in artifacts, runs that callwandb.Run.log()with table data, project access in the W&B App)Verification steps
evaluate-models.mdx: what the user should see in the Weave UI after running an evaluation, and in the W&B UI after logging a Table.log_tables.mdx: expected output after theCreate and log a tableprocedure (rendered table or run-console confirmation).tables-download.mdx: whatexample.csvshould contain and how to confirmdfis populated.tables-walkthrough.mdx: expected state after navigating to a run in "Visualize tables in your project workspace".visualize-tables.mdx: guidance for when the Compare button does not appear on hover (e.g., only one artifact version exists); verification cue for the step slider when_stepvalues are sparse or missing.Technical accuracy
evaluate-models.mdx:results = await evaluation.evaluate(model)at top level. Confirm whether the snippet assumes an async context (notebook/REPL) or requiresasyncio.run(...).summary, call = await evaluation.evaluate.call(evaluation, model). Verify the.call(...)signature; passingevaluationas both receiver and first argument looks suspicious.llm_judge_scoreris decorated with@weave.op()and usesawaitbut is defined asdef, notasync def. Verify intended behavior.evaluationobject is referenced. Verify the intended pattern for batch evals across multiple models.confidences = [model(img).max() for img, _ in test_data]recomputes predictions. Verify whether confidences should be cached from the prior loop.log_tables.mdx:#create-and-log-a-new-table,#table-logging-modes) may no longer match the current headings (Create and log a table,Logging modes). Verify against Mintlify's anchor generation.MUTABLE/INCREMENTALare the public API constants (not enum members likeLogMode.MUTABLE) before wrapping them in backticks in headings.INCREMENTALmode version note cites W&B Server v0.70.0+. Confirm whether a separate SDK-version constraint applies or whether SaaS users have a different availability window.resume_stepandfinal_stepin the Resume example are referenced but not defined in the snippet. Decide whether to inline definitions or cross-link to resume runs.tables-download.mdx:artifact.get(table, "table_name")(two args) but the code usesartifact.get("my_table")(one arg). Verify the correct signature against the current SDK.wandb.init() as ruses the variable namer; confirm whether the team's idiom isrun.table.get_dataframe()is the canonical method on the currentwandb.TableAPI./models/artifacts/construct-an-artifact/is the intended target for the "reference documentation on artifacts" bullet.tables-gallery.mdx:http://wandb.me/audio-transfershould behttps.tables-walkthrough.mdx:/models/ref/python/experiments/run.md/#method-runloghas a.mdextension mid-path. Verify the route resolves under Mintlify.my_tableandrun.logindented two spaces instead of four under thewithblock). Confirm intent or correct in a code-formatting pass.visualize-tables.mdx:#custom-step-keys(step 7 of the query-panel procedure) targets a heading "Custom step key" (singular), which renders as#custom-step-key. Confirm the anchor resolves.Missing content
evaluate-models.mdx: W&B Models Registry andlog_mode="MUTABLE"are referenced without inline explanation or link. Add short definitions or links so the page remains self-contained.log_tables.mdx:Examplessection reuses placeholder functions (load_eval_data(),model.predict(),get_training_batch(), etc.) defined earlier in Note callouts but does not repeat the placeholder caveats. Add a single shared note at the top ofExamplesor link to a canonical example dataset/loader.INCREMENTAL+IMMUTABLEpattern (lines 153–180) effectively doubles storage. Add (or confirm the deliberate absence of) explicit guidance about the cost/storage tradeoff.tables-download.mdx:pandasdependency.tables-gallery.mdx:<Frame>image, unlike every other entry. Confirm whether an image is missing or this is intentional.wandb.me/dsviz-nature-colab,wandb.me/audio-transfer,wandb.me/dsviz-cars-demo,wandb.me/dsviz-mnist-colab) point to externally maintained notebooks. Confirm they remain runnable.tables-walkthrough.mdx:<Card>or button component is present. Verify whether the component was omitted or the sentence should be removed.visualize-tables.mdx:{/* To do, add steps */}/{/* To do */}) where step-by-step instructions are not yet written.Run History Tables Stepper,Run History Plots Stepper,Stepper) appears to be an unfilled comparison table.How to review