fix: address review feedback

CI: add permissions: contents: read, persist-credentials: false.
package.json: nested types in exports for CJS/ESM, add typecheck script.
eid.ts: fix %s injection in JFormatter (single-pass replace).
preconditions.ts: fix off-by-one in checkElementIndex (index >= size).
index.ts: remove misleading backward compat block.

Assisted-by: 🤖 claude-opus-4-6@default

Author: cardil

.github/workflows/ci.yml

@@ -6,6 +6,9 @@ on:
   pull_request:
     branches: [master, develop]
 
+permissions:
+  contents: read
+
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
@@ -17,6 +20,8 @@ jobs:
     timeout-minutes: 5
     steps:
       - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
       - uses: actions/setup-node@v4
         with:
           node-version: 22
@@ -33,6 +38,8 @@ jobs:
         node-version: [20, 22]
     steps:
       - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
       - uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
@@ -47,6 +54,8 @@ jobs:
     needs: [lint, test]
     steps:
       - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
       - uses: actions/setup-node@v4
         with:
           node-version: 22

package.json

@@ -9,9 +9,14 @@
   "unpkg": "./dist/index.global.js",
   "exports": {
     ".": {
-      "types": "./dist/index.d.ts",
-      "import": "./dist/index.mjs",
-      "require": "./dist/index.cjs",
+      "import": {
+        "types": "./dist/index.d.ts",
+        "default": "./dist/index.mjs"
+      },
+      "require": {
+        "types": "./dist/index.d.cts",
+        "default": "./dist/index.cjs"
+      },
       "default": "./dist/index.mjs"
     },
     "./package.json": "./package.json"
@@ -24,13 +29,14 @@
   },
   "scripts": {
     "build": "tsup",
+    "typecheck": "tsc --noEmit",
     "test": "vitest run",
     "test:watch": "vitest",
     "test:coverage": "vitest run --coverage",
     "lint": "biome check src/",
     "lint:fix": "biome check --write src/",
     "format": "biome format --write src/",
-    "prepublishOnly": "npm run lint && npm run test && npm run build",
+    "prepublishOnly": "npm run typecheck && npm run lint && npm run test && npm run build",
     "clean": "rm -rf dist coverage"
   },
   "dependencies": {},

src/eid.ts

@@ -26,9 +26,10 @@ class JFormatter {
   }
 
   format(args: unknown[]): string {
-    const regex = /%s/;
-    const reducer = (p: string, c: unknown): string => p.replace(regex, String(c));
-    return args.reduce(reducer, this.template) as string;
+    let i = 0;
+    return this.template.replace(/%s/g, () => {
+      return i < args.length ? String(args[i++]) : "%s";
+    });
   }
 }
 

src/index.ts

@@ -35,15 +35,4 @@ import {
 } from "./exceptions";
 import { EidPreconditions } from "./preconditions";
 
-// Backward compatibility: attach preconditions and exceptions to Eid
-const preconditions = EidPreconditions;
-const exceptions = {
-  EidRuntimeException,
-  EidNullPointerException,
-  EidIllegalArgumentException,
-  EidIllegalStateException,
-  EidIndexOutOfBoundsException,
-};
-
-export { preconditions, exceptions };
 export default Eid;

src/preconditions.ts

@@ -43,7 +43,7 @@ function ensureEid(candidate: string | Eid | null | undefined): Eid {
 }
 
 function isIndexAndSizeIllegal(index: number, size: number): boolean {
-  return index < 0 || index > size;
+  return index < 0 || index >= size;
 }
 
 function isSizeIllegal(size: number): boolean {