From 9c980a851a054fa20962254f7ea09dbddf0b87d8 Mon Sep 17 00:00:00 2001 From: alexander-akait Date: Wed, 21 May 2025 19:46:18 +0300 Subject: [PATCH] chore: remove unused code --- packages/webpack-cli/src/types.ts | 1 - packages/webpack-cli/src/webpack-cli.ts | 28 ++----------------------- 2 files changed, 2 insertions(+), 27 deletions(-) diff --git a/packages/webpack-cli/src/types.ts b/packages/webpack-cli/src/types.ts index 8b7a17f8778..9e50dec7935 100644 --- a/packages/webpack-cli/src/types.ts +++ b/packages/webpack-cli/src/types.ts @@ -43,7 +43,6 @@ interface IWebpackCLI { toKebabCase: StringFormatter; capitalizeFirstLetter: StringFormatter; checkPackageExists(packageName: string): boolean; - getAvailablePackageManagers(): PackageManager[]; getDefaultPackageManager(): PackageManager | undefined; doInstall(packageName: string, options?: PackageInstallOptions): Promise; loadJSONFile(path: Path, handleError: boolean): Promise; diff --git a/packages/webpack-cli/src/webpack-cli.ts b/packages/webpack-cli/src/webpack-cli.ts index 6f397689eff..f1762cac85e 100644 --- a/packages/webpack-cli/src/webpack-cli.ts +++ b/packages/webpack-cli/src/webpack-cli.ts @@ -184,33 +184,7 @@ class WebpackCLI implements IWebpackCLI { return false; } - getAvailablePackageManagers(): PackageManager[] { - const { sync } = require("cross-spawn"); - const installers: PackageManager[] = ["npm", "yarn", "pnpm"]; - const hasPackageManagerInstalled = (packageManager: PackageManager) => { - try { - sync(packageManager, ["--version"]); - - return packageManager; - } catch (_err) { - return false; - } - }; - const availableInstallers = installers.filter((installer) => - hasPackageManagerInstalled(installer), - ); - - if (!availableInstallers.length) { - this.logger.error("No package manager found."); - - process.exit(2); - } - - return availableInstallers; - } - getDefaultPackageManager(): PackageManager | undefined { - const { sync } = require("cross-spawn"); const hasLocalNpm = fs.existsSync(path.resolve(process.cwd(), "package-lock.json")); if (hasLocalNpm) { @@ -229,6 +203,8 @@ class WebpackCLI implements IWebpackCLI { return "pnpm"; } + const { sync } = require("cross-spawn"); + try { // the sync function below will fail if npm is not installed, // an error will be thrown