Skip to content

Request: New PyPI Release with Japanese ITN Support #321

@wujin941005

Description

@wujin941005

Current Status

  • Last PyPI release: v1.0.4.1 (August 1, 2024)
  • Japanese ITN added: November 11, 2024 (PR Support Japanese TN&ITN #281)
  • Time since last release: ~17 months

Issues Preventing pip install from GitHub

  1. setup.py bug (line 18):
    python
    version = sys.argv[-1].split("=")[1] # IndexError if no version arg
    This breaks pip install git+https://github.com/...

  2. Missing Japanese data in package_data:
    'itn': ['.fst', 'chinese/data//.tsv'], # Missing: 'japanese/data//*.tsv'

Request
Could you please:

  1. Fix setup.py to handle version gracefully (e.g., default to "0.0.0" or read from a VERSION file)
  2. Add Japanese data files to package_data
  3. Publish a new release to PyPI

Impact
Users wanting Japanese ITN must manually clone repo, run python setup.py install version=X.X.X, and copy data files - this breaks CI/CD pipelines.

Thank you for the great project! 🙏

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions