Parenting issue when setting localPos of the hologram!

[raven1934]

Describe the bug

Hey, anyone savvy enough here to check if parented holos have clamped distance from the parent that is in the ballpark of 16384 units, earlier i was using rangers to measure distances to which to project my snipers red dot, but for whatever reason when i use the parenting on my holos (to avoid the delay of moving the dot) it seems that the hologram can only at max move up to roughly at 16384 mark and despite receiving correct distance/position the holo cannot travel further than this distance from the parent prop... If true and if this isn't engine limit could we maybe get rid of the limit if its implemented by mod itself.

How to reproduce the bug

Try to move a prop parented hologram beyond the roughly 16384 unit mark on a long map, and then return its distance to the parent objects position... I'm already pulling my hair if this is a possibility as it def affects lot of the projects I've made in past that deal with semi-long distances.

@name ParentingDistanceClampTest
@inputs 
@outputs 
@persist Emitter:entity
@trigger none 
@strict
@model

if(first())
{
    Emitter=propSpawn("models/hunter/blocks/cube025x025x025.mdl",entity():pos()+vec(0,0,50),ang(0,0,0),1)
    Emitter:noCollideAll(1)
    
    #entity():propNotSolid(1)
    #entity():setPos(Emitter:massCenter())
    #entity():setAng(Emitter:angles())
    #entity():parentTo(Emitter)
    #entity():noCollideAll(1)

    holoCreate(1)
    holoModel(1,"hq_sphere")
    holoParent(1,Emitter)
    holoLocalPos(1,Emitter:massCenterL())
    holoLocalAng(1,ang(0,0,0))
    holoDisableShading(1,1)
    holoColor(1,vec(255,0,0))
    holoMaterial(1,"models/debug/debugwhite")    

    Filter=array(Emitter,entity(),holoEntity(1))
    
    rangerPersist(1)
    rangerHitWater(1)
    rangerDefaultZero(0)
    rangerFilter(Filter)
    rangerHitEntities(0)
}

R=rangerOffset(Emitter:massCenter(),Emitter:massCenter()+Emitter:forward()*65565)

holoLocalPos(1,Emitter:massCenterL()+vec(R:distance(),0,0))

print(round((holoEntity(1):pos()-Emitter:pos()):length())+" "+round(R:distance(),0))

runOnTick(1)


#Works fine when using normal holoPos() but when using parenting and holoLocalPos() it just doesnt work at all after like 16.5 k units from the parent

#@name 
#@inputs 
#@outputs 
#@persist 
#@trigger none 
#@strict
#
#holoCreate(1)
#holoDisableShading(1,1)
#
#timer(tickRealInterval()*2,0,function(){
#    let R = rangerOffset(entity():pos(),entity():pos()+entity():forward()*65565)
#    holoPos(1,R:position())
#})

This code should be able to indicate the issue, the commented lines are from friend whos ranger works fine as it is not parenting the holo and then setting its localPos

[Mihoshika]

uses setLocalPos
which calls clampPos
which clamps between -16384 and 16384.

[raven1934]

Ah I tried to trace the function to wirelib from the e2 hologram script, but i guess i failed... Is it possible to ask for a increase on the clamping range for the function or is there some performance/crash potential if it's too high. I just see the effect on the entities that are parented, like holoemitters and holograms etc. that would make quite cool laser rifle effect but sadly the limit is atleast on our servers map too small. I discussed with a friend about possibility of using other holos as proxies and then hierarchy hopping between them according to the measured distance, but I feel it would be such a waste of hologram. Still big thanks for showing me where to look, I assumed it would be in the wirelib.lua since the function inside hologram file seemed to point that way.

[Mihoshika]

#1673
Did a bit of digging, a bit of the logic behind it, though that's referring to rangers rather than holos.

[raven1934]

Hmm, I used the rangers distance on the setLocalPos and the readout seems right, so maybe this is a lingering old protective measure, what do you think? I get values back that are well above the 32768 units on ranger... on our map the diagonal is like 37k or so and it seems to measure just fine.

[Mihoshika]

If you'd read the whole of what is discussed, rangers use the diagonal as a max. I don't claim to know why the limits are set as they are. Anyways, you can just try testing making it ~37k clamp instead locally, then making a PR if it doesn't crash anything.

[raven1934]

Seems yeah like path to do things, but I've got practically zero experience in forking and merging the code and same goes for lua programming, all I've done for semi-long is just use e2. :p