Address copilot review comments

Author: rosik

ydb/tests/library/fixtures/__init__.py

@@ -2,6 +2,7 @@
 import contextlib
 import logging
 import os
+import copy
 
 import pytest
 
@@ -171,17 +172,13 @@ def stop_pool():
 
 @pytest.fixture(scope='module', params=[True, False], ids=["encryption_enabled", "encryption_disabled"])
 def encryption_enabled(request):
-    """
-    Parametrized fixture that runs tests with both encryption enabled and disabled.
-    """
+    """Parametrized fixture that runs tests with both encryption enabled and disabled."""
     return request.param
 
 
 @pytest.fixture(scope='module')
 def ydb_cluster_configuration_with_encryption_parametrized(ydb_cluster_configuration, encryption_enabled):
-    """
-    Extended cluster configuration that includes encryption settings based on the parametrized fixture.
-    """
-    config = ydb_cluster_configuration.copy()
+    """Extended cluster configuration that includes encryption settings based on the parametrized fixture."""
+    config = copy.deepcopy(ydb_cluster_configuration)
     config['enable_pool_encryption'] = encryption_enabled
     return config

ydb/tests/library/harness/kikimr_config.py

@@ -686,7 +686,7 @@ def grpc_tls_ca(self):
     @property
     def domains_txt(self):
         app_config = config_pb2.TAppConfig()
-        assert not self.enable_pool_encryption, "pool encryption isn't addressed in domains.txt"
+        assert not self.enable_pool_encryption, "pool encryption is not addressed in domains.txt"
         Parse(read_binary(__name__, "resources/default_domains.txt"), app_config.DomainsConfig)
         return app_config.DomainsConfig
 

ydb/tests/library/harness/kikimr_runner.py

@@ -642,6 +642,9 @@ def __register_slot(self, tenant_affiliation=None, encryption_key=None, seed_nod
             else self.nodes[1].grpc_port
         )
 
+        if tenant_affiliation is None:
+            tenant_affiliation = "dynamic"
+
         if encryption_key is None and self.__configurator.enable_pool_encryption:
             workdir = os.path.join(self.__configurator.working_dir, self.__cluster_name)
             slug = tenant_affiliation.replace('/', '_')
@@ -662,7 +665,7 @@ def __register_slot(self, tenant_affiliation=None, encryption_key=None, seed_nod
             udfs_dir=self.__common_udfs_dir,
             role='slot',
             node_broker_port=node_broker_port,
-            tenant_affiliation=tenant_affiliation if tenant_affiliation is not None else 'dynamic',
+            tenant_affiliation=tenant_affiliation,
             encryption_key=encryption_key,
             binary_path=self.__configurator.get_binary_path(slot_index),
             seed_nodes_file=seed_nodes_file,