Skip to content

Conversation

@rosik
Copy link
Collaborator

@rosik rosik commented Dec 5, 2025

@ydbot
Copy link
Collaborator

ydbot commented Dec 5, 2025

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶  Run tests

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

🟢 2025-12-08 12:56:04 UTC The validation of the Pull Request description is successful.

@rosik rosik marked this pull request as ready for review December 8, 2025 12:50
Copilot AI review requested due to automatic review settings December 8, 2025 12:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces parametrized testing for pool encryption functionality by creating reusable fixtures that run tests with encryption both enabled and disabled. The changes enable a single test module to be automatically executed in both encrypted and non-encrypted configurations.

Key changes:

  • Added parametrized fixtures for encryption testing that automatically run tests with encryption enabled/disabled
  • Implemented auto-generation of encryption keys for test slots when pool encryption is enabled
  • Updated configuration generator to apply encryption mode to storage pool types

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
ydb/tests/library/fixtures/init.py Adds encryption_enabled parametrized fixture and ydb_cluster_configuration_with_encryption_parametrized fixture that extends cluster configuration with encryption settings
ydb/tests/library/harness/kikimr_runner.py Implements auto-generation of encryption keys and configuration files for test slots when pool encryption is enabled
ydb/tests/library/harness/kikimr_config.py Adds enable_pool_encryption parameter to KikimrConfigGenerator and configures encryption mode for storage pools in YAML config
ydb/tests/functional/tenants/test_auth_system_views.py Updates ydb_configurator fixture to use the new encryption-parametrized configuration fixture

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rosik rosik force-pushed the test-encryption-4 branch from 15189f0 to a4d1d6c Compare December 8, 2025 18:26
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 8, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 8, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 8, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 8, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 8, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

2025-12-08 18:29:22 UTC Pre-commit check linux-x86_64-release-asan for 799cd5d has started.
2025-12-08 18:29:41 UTC Artifacts will be uploaded here
2025-12-08 18:31:50 UTC ya make is running...
🟡 2025-12-08 19:11:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1794 1772 0 8 6 8

🟢 2025-12-08 19:11:59 UTC Build successful.
🟢 2025-12-08 19:12:21 UTC ydbd size 3.8 GiB changed* by +47.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4921cae merge: 799cd5d diff diff %
ydbd size 4 129 997 880 Bytes 4 130 046 976 Bytes +47.9 KiB +0.001%
ydbd stripped size 1 533 169 816 Bytes 1 533 185 496 Bytes +15.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

2025-12-08 18:30:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 799cd5d has started.
2025-12-08 18:30:33 UTC Artifacts will be uploaded here
2025-12-08 18:32:39 UTC ya make is running...
🟢 2025-12-08 19:20:28 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6733 6592 0 0 130 11

🟢 2025-12-08 19:20:37 UTC Build successful.
🟢 2025-12-08 19:20:58 UTC ydbd size 2.3 GiB changed* by -1.6 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 33bff08 merge: 799cd5d diff diff %
ydbd size 2 467 827 992 Bytes 2 466 169 536 Bytes -1.6 MiB -0.067%
ydbd stripped size 525 130 656 Bytes 524 847 552 Bytes -276.5 KiB -0.054%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants