From 9238ec23a1982232ae0d998271d1149206ecadec Mon Sep 17 00:00:00 2001 From: Sergei Predvoditelev Date: Sat, 9 May 2026 15:52:11 +0300 Subject: [PATCH 1/3] Fix directory permission assertion in test to be umask-aware --- composer.json | 2 +- .../CreateNestedDirectory/CreateNestedDirectoryTest.php | 2 +- tests/Support/TestHelper.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/composer.json b/composer.json index 026491b..3c7c8b1 100644 --- a/composer.json +++ b/composer.json @@ -65,7 +65,7 @@ "scripts": { "cs-fix": "php-cs-fixer fix", "rector": "rector", - "test": "phpunit --testdox --no-interaction", + "test": "phpunit", "test-watch": "phpunit-watcher watch" } } diff --git a/tests/ItemsStorage/CreateNestedDirectory/CreateNestedDirectoryTest.php b/tests/ItemsStorage/CreateNestedDirectory/CreateNestedDirectoryTest.php index 474fc52..8c320d5 100644 --- a/tests/ItemsStorage/CreateNestedDirectory/CreateNestedDirectoryTest.php +++ b/tests/ItemsStorage/CreateNestedDirectory/CreateNestedDirectoryTest.php @@ -65,6 +65,6 @@ public function testDirectoryPermission(): void $storage = new ItemsStorage($directory . '/items.php'); $storage->add(new Permission('createPost')); - $this->assertSame(0755, TestHelper::getDirectoryPermissions($directory)); + $this->assertSame(0775, TestHelper::getDirectoryPermissions($directory)); } } diff --git a/tests/Support/TestHelper.php b/tests/Support/TestHelper.php index 076c7e1..d4b9cfd 100644 --- a/tests/Support/TestHelper.php +++ b/tests/Support/TestHelper.php @@ -19,6 +19,6 @@ public static function getCurrentErrorHandler(): ?callable public static function getDirectoryPermissions(string $path): int { - return octdec(substr(sprintf('%o', fileperms($path)), -4)); + return octdec(substr(sprintf('%o', fileperms($path)), -4)) & ~umask(); } } From c14f6ad83a10efad22e7fb59aac6be2ed73d684f Mon Sep 17 00:00:00 2001 From: Sergei Predvoditelev Date: Sun, 10 May 2026 10:19:48 +0300 Subject: [PATCH 2/3] fix --- .../CreateNestedDirectory/CreateNestedDirectoryTest.php | 6 ++---- tests/Support/TestHelper.php | 5 ----- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/tests/ItemsStorage/CreateNestedDirectory/CreateNestedDirectoryTest.php b/tests/ItemsStorage/CreateNestedDirectory/CreateNestedDirectoryTest.php index 8c320d5..de14329 100644 --- a/tests/ItemsStorage/CreateNestedDirectory/CreateNestedDirectoryTest.php +++ b/tests/ItemsStorage/CreateNestedDirectory/CreateNestedDirectoryTest.php @@ -55,9 +55,6 @@ public function testRestoreErrorHandler(): void assertSame($errorHandler, $currentErrorHandler); } - /** - * @requires OS Linux - */ public function testDirectoryPermission(): void { $directory = self::RUNTIME_DIRECTORY . '/test/create/nested/directory-permissions'; @@ -65,6 +62,7 @@ public function testDirectoryPermission(): void $storage = new ItemsStorage($directory . '/items.php'); $storage->add(new Permission('createPost')); - $this->assertSame(0775, TestHelper::getDirectoryPermissions($directory)); + $this->assertTrue(is_writable($directory)); + $this->assertTrue(is_readable($directory)); } } diff --git a/tests/Support/TestHelper.php b/tests/Support/TestHelper.php index d4b9cfd..bd01725 100644 --- a/tests/Support/TestHelper.php +++ b/tests/Support/TestHelper.php @@ -16,9 +16,4 @@ public static function getCurrentErrorHandler(): ?callable restore_error_handler(); return $currentHandler; } - - public static function getDirectoryPermissions(string $path): int - { - return octdec(substr(sprintf('%o', fileperms($path)), -4)) & ~umask(); - } } From 218d9401ec46fb5aef018b545521f3e6f9283346 Mon Sep 17 00:00:00 2001 From: vjik <525501+vjik@users.noreply.github.com> Date: Sun, 10 May 2026 07:20:23 +0000 Subject: [PATCH 3/3] Apply PHP CS Fixer and Rector changes (CI) --- tests/Support/TestHelper.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/Support/TestHelper.php b/tests/Support/TestHelper.php index bd01725..47566e6 100644 --- a/tests/Support/TestHelper.php +++ b/tests/Support/TestHelper.php @@ -4,8 +4,6 @@ namespace Yiisoft\Rbac\Php\Tests\Support; -use function sprintf; - final class TestHelper { private function __construct() {}