fix: don't enable method snippets before ( in some edge-cases

Author: zardoy

src/onCompletionAccepted.ts

@@ -55,7 +55,10 @@ export default (tsApi: { onCompletionAccepted }) => {
             if (!documentation?.startsWith(dataMarker)) return
             const parsed = JSON.parse(documentation.slice(dataMarker.length, documentation.indexOf('e-->')))
             const { methodSnippet: params, isAmbiguous } = parsed
-            if (!params) return
+            // nextChar check also duplicated in completionEntryDetails for perf, but we need to run this check again with correct position
+            const startPos = editor.selection.start
+            const nextChar = editor.document.getText(new vscode.Range(startPos, startPos.translate(0, 1)))
+            if (!params || ['(', '.', '`'].includes(nextChar)) return
 
             if (isAmbiguous && lastAcceptedAmbiguousMethodSnippetSuggestion !== suggestionName) {
                 lastAcceptedAmbiguousMethodSnippetSuggestion = suggestionName

src/specialCommands.ts

@@ -281,4 +281,11 @@ export default () => {
             },
         )
     })
+
+    registerExtensionCommand('copyFullType', async () => {
+        const response = await sendCommand<RequestResponseTypes['getFullType']>('getFullType')
+        if (!response) return
+        const { text } = response
+        await vscode.env.clipboard.writeText(text)
+    })
 }

typescript/src/completionEntryDetails.ts

@@ -49,6 +49,7 @@ export default function completionEntryDetails(
         prior.displayParts = [{ kind: 'text', text: detailPrepend }, ...prior.displayParts]
     }
     if (!prior) return
+    // might be incorrect: write [].entries() -> []|.entries|() -> []./*position*/e
     const nextChar = sourceFile.getFullText().slice(position, position + 1)
 
     if (enableMethodCompletion && c('enableMethodSnippets') && !['(', '.', '`'].includes(nextChar)) {

typescript/src/completions/objectLiteralCompletions.ts

@@ -66,11 +66,10 @@ export default (prior: ts.CompletionInfo): ts.CompletionEntry[] | void => {
         const insertSnippetVariant = completingStyleMap.find(([, detector]) => detector(type!, typeChecker))?.[0] ?? fallbackSnippet
         if (!insertSnippetVariant) continue
         const [insertSnippetText, insertSnippetPreview] = typeof insertSnippetVariant === 'function' ? insertSnippetVariant() : insertSnippetVariant
-        const insertText = entry.name + insertSnippetText
+        const insertText = entry.name.replace(/\$/g, '\\$') + insertSnippetText
         const index = entries.indexOf(entry)
         entries.splice(index + (keepOriginal === 'before' ? 1 : 0), keepOriginal === 'remove' ? 1 : 0, {
             ...entry,
-            name: entry.name.replace(/\$/g, '\\$'),
             // todo setting incompatible!!!
             sortText: entry.sortText,
             labelDetails: {