🎨 Palette: [UX improvement] Fix invisible text on button hover#75
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: The
.button:hoverCSS class was updated to explicitly definecolor: var(--secondary-color);andborder-color: var(--secondary-color);, along with a 2px solid transparent border on the base.buttonclass. Transition properties were updated to smoothly animate these color changes.🎯 Why: Previously, the button background inverted to black
#000000on hover, but the text color (which was also black) did not update. This resulted in invisible text and icons, breaking accessibility and creating a confusing user experience. Adding a transparent border prevents layout shifting on hover while providing a space for a focus-friendly border.📸 Before/After: No visual regressions. Hover screenshots generated via Playwright.
♿ Accessibility: This directly fixes a WCAG color contrast violation on interactive elements, ensuring text remains visible and legible during hover states. I also added a journal entry to
.Jules/palette.mdto document this learning.PR created automatically by Jules for task 15857262264434400233 started by @0m364