Skip to content

🎨 Palette: Improve accessibility of OSINT modal triggers#76

Open
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette-osint-accessibility-4991332482287143075
Open

🎨 Palette: Improve accessibility of OSINT modal triggers#76
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette-osint-accessibility-4991332482287143075

Conversation

@0m364
Copy link
Copy Markdown
Owner

@0m364 0m364 commented May 7, 2026

💡 What: Added role="button" and aria-haspopup="dialog" to the #sitrep-btn "OSINT" modal trigger links across the site (products.html, concepts.html, contact.html). Added a keydown event listener in modal.js so that pressing the Spacebar triggers the modal.

🎯 Why: The OSINT triggers were implemented as standard <a> tags with href="#". Screen readers would announce them as navigation links rather than actionable buttons, and keyboard users could not trigger them using the Spacebar (which would default to scrolling the page). This change aligns the markup and behavior with user expectations for dialog triggers.

📸 Before/After: Visual appearance remains identical, but keyboard interactions (Spacebar) now function correctly.

♿ Accessibility: Ensures that elements acting as buttons are semantically announced as buttons (role="button") and explicitly indicate they open a dialog (aria-haspopup="dialog"). Also guarantees native button-like keyboard interactions (Enter and Space).


PR created automatically by Jules for task 4991332482287143075 started by @0m364

- Add role="button" and aria-haspopup="dialog" to OSINT trigger links.
- Bind keydown listener for Spacebar to ensure keyboard accessibility.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant