🎨 Palette: Make OSINT modal triggers accessible for keyboard users#80
Conversation
- Add `role="button"` and `aria-haspopup="dialog"` to all OSINT modal triggers. - Add Javascript listener for Spacebar inside modal.js to ensure native button behaviour for keyboard users. - Add journal entry for Anchor Tags as Buttons Accessibility in .Jules/palette.md
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added
role="button"andaria-haspopup="dialog"to anchor tags used as buttons to open the OSINT sitrep modal. Also added a JS keydown event listener to allow the modal to be opened using the Spacebar.🎯 Why: To improve keyboard navigation and screen reader support. Native anchor tags act as links and respond to Enter but not Spacebar.
📸 Before/After: Visuals haven't changed, but it behaves as a button for keyboard users now.
♿ Accessibility: Ensures that interactive
<a href="#">tags used as custom buttons communicate their proper semantic role ("button") to screen readers, explicitly indicate they control a dialog pop-up (aria-haspopup), and provide full standard keyboard accessibility by responding to both the 'Enter' (native) and 'Spacebar' (custom JS) keys without inadvertently scrolling the page.PR created automatically by Jules for task 2438054450958329565 started by @0m364