fix(headers): OrigHeaderMap constructor drops header casing#557
Merged
0x676e67 merged 1 commit into0x676e67:mainfrom Apr 9, 2026
Merged
fix(headers): OrigHeaderMap constructor drops header casing#5570x676e67 merged 1 commit into0x676e67:mainfrom
0x676e67 merged 1 commit into0x676e67:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the header name extraction logic in src/header.rs by directly converting PyBackedStr to Bytes. A suggestion was made to use a let-else statement instead of a match block to improve the readability of the extraction process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: OrigHeaderMap constructor drops header casing
Problem
OrigHeaderMap(list)does not preserve the casing of header names passed to it.For example:
sends
host,user-agent,accepton the wire — all lowercase — despite the title-case input.Root cause
In
src/header.rs, thenew()constructor converts each string to aHeaderNameviaHeaderName::from_bytes()before inserting it into the map:HeaderNameis always stored lowercase (per the HTTP spec's normalisation). When insertedinto
OrigHeaderMap, it becomesKind::Standard, whoseas_ref()returns the lowercasecanonical form — so the original casing is permanently lost.
By contrast, the
insert()method and theFromPyObjectimpl both useBytes::from_owner()which goes through
Kind::Cased, preserving the exact bytes as given.Fix
Change
new()to use the sameBytespath asinsert()andFromPyObject:Impact
Any code that constructs
OrigHeaderMapvia the constructor (e.g.OrigHeaderMap(['Host', 'X-Custom']))now correctly preserves the supplied casing. The
insert()method was already correct and is unaffected.