Fix critical bugs, improve version checking, and add Korean localization - #1
Open
ava-jahlee wants to merge 1 commit into
Open
ava-jahlee wants to merge 1 commit into
ava-jahlee wants to merge 1 commit into
Conversation
- Fix NPE crash in VersionChecker.scanForVersions when URL fetch fails - Fix failed URLs permanently cached as null (now uses Optional) - Replace string equals with normalized version comparison - Add dedicated HTTP thread pool instead of blocking ForkJoinPool - Replace Thread.sleep with ScheduledExecutorService for rate limiting - Fix Timer thread leak in FXUtils.runLaterDelayed - Add scraping rules for MCCC, WickedWhims, Basemental, NisaK, Lumpinou, SimRealist - Move data directory to ~/.sims4modchecker/ with legacy migration - Add URL scheme whitelist for image downloads - Add Korean localization - Add regex capture group validation - Remove unused GluonFX plugin, add Java 23 toolchain - Bump version to 1.1 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files Changed (8 files, +248 / -122)
Test Plan