fix: correct TypeScript code examples and expected outputs in notes.md#173
Open
giwaov wants to merge 1 commit into0xMiden:mainfrom
Open
fix: correct TypeScript code examples and expected outputs in notes.md#173giwaov wants to merge 1 commit into0xMiden:mainfrom
giwaov wants to merge 1 commit into0xMiden:mainfrom
Conversation
Fixes 0xMiden#161 Fixed three code correctness issues in the Notes & Transactions guide: 1. Fixed expected output format for balance check - Changed 'Ok(1000)' to '1000' to match TypeScript Number() output - TypeScript getBalance() returns a number, not a Result wrapper 2. Fixed send transaction log message in expected output - Changed to match actual TypeScript console.log message - Was showing Rust println! format instead of TypeScript output 3. Removed unused ConsumableNoteRecord import in send section - Import was copied from consume example but never used - Cleaned up to match actual code requirements All fixes ensure expected outputs accurately reflect what the code produces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #161
This PR corrects three code correctness issues in the Notes & Transactions quickstart guide.
Bugs Fixed
1. Fixed TypeScript balance output format
Ok(1000)to1000to match TypeScript Number() output2. Fixed send transaction log message mismatch
3. Removed unused ConsumableNoteRecord import
Impact
Changes
docs/builder/quick-start/notes.md: 2 insertions, 3 deletions