Skip to content

fix/4191: Search template generation when Post Search feature is disabled#4297

Open
Sidsector9 wants to merge 3 commits intodevelopfrom
fix/4191
Open

fix/4191: Search template generation when Post Search feature is disabled#4297
Sidsector9 wants to merge 3 commits intodevelopfrom
fix/4191

Conversation

@Sidsector9
Copy link
Copy Markdown
Member

Description of the Change

Instant Results failed to generate a search template when the Post Search feature was disabled. The Post indexable was never activated, so the query in get_search_template() fell back to MySQL instead of Elasticsearch and no template was captured.

Closes #4191

How to test the Change

Changelog Entry

Fixed - Search template generation when Post Search feature is disabled

Credits

Props @burhandodhy @Sidsector9

Checklist:

@Sidsector9 Sidsector9 self-assigned this Mar 1, 2026
@Sidsector9 Sidsector9 requested a review from felipeelia March 1, 2026 18:17
@felipeelia
Copy link
Copy Markdown
Member

Wouldn't it make more sense to make Instant Results dependent on the Post Search feature?

@felipeelia felipeelia added this to the 5.4.0 milestone Apr 21, 2026
@Sidsector9
Copy link
Copy Markdown
Member Author

Sidsector9 commented Apr 28, 2026

@felipeelia my implementation was based on the absence of checks for Post Search, for both Autosuggest and Instant Results. It will make sense if we make both features dependent on Post Search feature and add a message under each result that "This feature requires Post Search to be enabled". Something like this:

Screenshot 2026-04-28 at 11 28 33 PM Screenshot 2026-04-28 at 11 28 38 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Instant Results template doesn’t generate when Post Search feature is disabled

2 participants