Merged
Conversation
Member
|
@peterwilsoncc @dkotter not certain if we similarly need to version bump to 2.0.1 in distributor/includes/rest-api.php Line 385 in 46a26fa |
Member
|
@dkotter @peterwilsoncc @ravinderk open to any of the following items currently in the 2.0.1 milestone getting wrapped up, merged, and included in the release:
But come Monday, we'll want to continue with the 2.0.1 in any case to get the fix out for the distributed author issue (and other updates in the release). |
Contributor
Collaborator
Only needed for crossing the divide so no need to bump. |
peterwilsoncc
previously approved these changes
Sep 19, 2023
Collaborator
peterwilsoncc
left a comment
There was a problem hiding this comment.
LGTM. I've just merged in a minor markdown fix so tests will need to rerun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
develop, create a release branch namedrelease/X.Y.Zfor your changes.distributor.php,package.json,readme.txtandtests/php/bootstrap.phpif it does not already reflect the version being released. Indistributor.phpupdate both the plugin "Version:" property and the pluginDT_VERSIONconstant.webpack.config.release.js.CHANGELOG.md.CREDITS.mdfile with any new contributors, confirm maintainers are accurate.README.mdis geared toward GitHub andreadme.txtcontains WordPress.org-specific content. The two are slightly different.@sincetags indicate the new version, replacingx.x.x,n.e.x.tand other placeholders.develop(or merge the Pull Request), then do the same fordevelopintotrunk(git checkout trunk && git merge --no-ff develop).trunkcontains the stable development version.drafttoready to merge.stablebranch to ensure the contents of the diffs are as expected.stablebranch and test it locally to ensure everything works as expected. It is recommended that you rename the existingdistributordirectory and check outstablefresh because switching branches does not delete files. This can be done withgit clone --single-branch --branch stable git@github.com:10up/distributor.gitstablebranch. Paste the changelog fromCHANGELOG.mdinto the body of the release and include a link to the closed issues on the milestone. The release should now appear under releases.stablebranch.Due date (optional)field) and link to GitHub release (in theDescriptionfield), then close the milestone.X.Y.Zdo not make it into the release, update their milestone toX.Y.Z+1,X.Y+1.0,X+1.0.0, orFuture Release.