fix: Enhance error handling in PgCheckpointer and update thread name …#43
Merged
fix: Enhance error handling in PgCheckpointer and update thread name …#43
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
PgCheckpointer's thread storage logic to provide clearer feedback on whether a thread was newly created or updated, and improves error handling. It also adds new tests to ensure the correct behavior of these changes.Enhancements to thread storage and update logic:
aput_threadmethod now returns a boolean indicating if a thread was newly created (True) or if an existing thread was updated (False). The logic first attempts to insert, and if the thread already exists, it updates only the necessary fields, defaulting to the existing thread name if none is provided. [1] [2] [3]Improved error handling:
aput_threadand_get_threadnow consistently raises the original exception object for better traceability. [1] [2]Testing and documentation:
aput_threadand its behavior on both insert and update paths.