Open
Conversation
Update FontSize to use TextSize and remove TextWrap since it's already set using TextWrapped
Remove TextWrap since TextWrapped already sets it
Replace GetProductInfo with GetProductInfoAsync to remove the deprecation warning. The functions behave exactly the same, but one is asynchronous
There was a problem hiding this comment.
Pull request overview
This pull request fixes deprecated Roblox API warnings by updating deprecated properties and methods to their current equivalents.
Changes:
- Replaced deprecated
GetProductInfowithGetProductInfoAsyncin MarketplaceService calls - Changed deprecated
FontSizeenum property toTextSizenumeric property - Removed redundant
TextWrapproperty (which was deprecated and duplicatesTextWrapped)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/VERSION.lua | Updated MarketplaceService call from deprecated GetProductInfo to GetProductInfoAsync |
| src/Elements/Widget.lua | Removed deprecated TextWrap property (redundant with TextWrapped) |
| src/Elements/Notice.lua | Changed deprecated FontSize enum to TextSize numeric property and removed redundant TextWrap |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Many thanks for all your PRs Ryan. These are wonderful 🙏 Excited to review and pull these in as soon as I start the next batch of update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes deprecated warnings by removing deprecated methods and using the up-to-date versions.
FontSizetoTextSizeEnuminstead of anumberTextWrapTextWrapis an alias forTextWrappedwhich is already setGetProductInfotoGetProductInfoAsyncScript Analysis Before
Script Analysis After