Skip to content

fix: correct node administrator permissions#13016

Merged
wanghe-fit2cloud merged 1 commit into
dev-v2from
pr@dev-v2@fix_node_admin
Jun 11, 2026
Merged

fix: correct node administrator permissions#13016
wanghe-fit2cloud merged 1 commit into
dev-v2from
pr@dev-v2@fix_node_admin

Conversation

@ssongliu

Copy link
Copy Markdown
Member

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7452675116

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +27 to +28
const res = await listNodeOptions(type);
return res.data || [];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve per-user node filtering

For enterprise non-admin users, this now calls the all-node /core/nodes/list endpoint instead of the previous /core/enterprise/users/nodes path, so the sidebar/node selectors that consume listNodes('all') can be populated with nodes outside the user's assigned node roles. In particular, Collapse.vue trusts this list when switching nodes, so a node admin with access to only one node can be shown and attempt to switch to every healthy bound node returned by the all-node API; keep using the user-scoped endpoint for non-admins or ensure this wrapper remains user-scoped.

Useful? React with 👍 / 👎.

@wanghe-fit2cloud wanghe-fit2cloud merged commit f476823 into dev-v2 Jun 11, 2026
4 checks passed
@wanghe-fit2cloud wanghe-fit2cloud deleted the pr@dev-v2@fix_node_admin branch June 11, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants