feat: update app upgrade logic#13032
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5e5674c91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| install.Version = detail.Version | ||
| install.AppDetailId = req.DetailID | ||
|
|
||
| if req.PullImage { |
There was a problem hiding this comment.
When req.PullImage is true and the registry pull fails here, this block now runs after copyAppDetailMissing and the scripts/build replacements above, but before compose.Down. If the user upgraded without a backup, rollBackApp is a no-op, so the task is marked failed while the install directory has already been partially advanced to the target version, leaving the still-running old app with new support files/scripts and making a retry or rollback depend on manual cleanup. Keep the pull after computing the new compose, but before any filesystem mutations.
Useful? React with 👍 / 👎.
3 participants
No description provided.