Conversation
…moved fields The edit path's problem_list branch still wrote Problem rows with paragraph_id/document_id, columns that no longer exist on the model, so any PUT carrying problem_list failed with FieldError while the create path already used Problem + ProblemParagraphMapping. Align edit with create: replace the paragraph's mappings, reusing existing same-content problems. Restores create/edit symmetry for the public REST API. Signed-off-by: wangzifei <wangzifei@cit.group.hk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
ParagraphSerializers.Operate.edit的problem_list分支仍是 v1 遗留代码:直接以paragraph_id/document_id查询并构造Problem,而这些字段在模型与迁移中早已不存在,公开 REST APIPUT .../paragraph/{id}携带problem_list时必然FieldError500。创建路径(Create.save)已迁移为Problem+ProblemParagraphMapping,编辑路径未同步。修复
ProblemParagraphManage复用同内容问题并重建映射。