Skip to content

Bump HRX: llama.cpp 40c4ccb76e48 + hrx-system 82804197bcbe - #610

Open
bong-water-water-bong wants to merge 1 commit into
mainfrom
bump-hrx/40c4ccb76e48-82804197bcbe
Open

bong-water-water-bong wants to merge 1 commit into
mainfrom
bump-hrx/40c4ccb76e48-82804197bcbe

Conversation

@bong-water-water-bong

Copy link
Copy Markdown
Collaborator

Moves the HRX submodules along our line. AMD's tested pair (ROCm/ggml-staging-automation) is llama.cpp 1ec5a7a69da5 + hrx-system 5f4dfc8731a1; the workflow merges it into our branches (a conflict fails the run and names the files).

from to
third_party/llama.cpp (1bit-MONSTER/llama.cpp 1bit/hrx-vulkan-patched) e7e5cd08f9bb 40c4ccb76e48
third_party/hrx-system (1bit-MONSTER/hrx-system 1bit/main) 82804197bcbe 82804197bcbe

hrx-system HELD at 82804197bcbe by config/hrx-system-hold.config (AMD's tested pin is 5f4dfc8731a1).

llama.cpp commits new to the engine:

CI here builds without HRX. Before merging, on Strix Halo run the long-prompt correctness
probe and test-backend-ops -b HRX0; record the exact validated hrx-system pin in
config/hrx-long-prompt-validated-pin.config:
python3 tests/hrx_long_prompt.py
cmake -B build -G Ninja -DONEBIT_HRX=ON && cmake --build build --target onebit && for d in hrx cpu; do tests/serve_e2e.sh build/1bit <Qwen3-0.6B Q4_K_M .gguf> $d; done

@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

153 - Partially compliant

Compliant requirements:

  • The trace file is now opened with explicit 0644 mode
  • Error handling added for file opening failures

Non-compliant requirements:

  • None

Requires further human verification:

  • None

152 - Partially compliant

Compliant requirements:

  • Integer multiplication cast fixed in laya/scorer.cpp
  • Workflow permissions declared in ci.yml

Non-compliant requirements:

  • None

Requires further human verification:

  • None

445 - Partially compliant

Compliant requirements:

  • The PR updates the submodule to the latest commit
  • The test cases are updated to reflect the new dispatch behavior

Non-compliant requirements:

  • The PR does not address the root cause of the 49 failing test cases, but merely updates the submodule

Requires further human verification:

  • The classification of test cases (A-D) requires further human review to determine if the expectations need to be updated or if there are actual behavior changes that need to be addressed
⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Submodule Update

The PR updates the llama.cpp submodule to commit 40c4ccb76e48aafd44e024b0d2bb27b38bf54015. This update includes several fixes and changes related to HRX, including kernel name translation, norm input contiguity, and dispatch matching. While the update itself is straightforward, it's important to verify that all the changes are compatible with the current codebase and that no regressions are introduced.

Subproject commit 40c4ccb76e48aafd44e024b0d2bb27b38bf54015
Architecture Registry Update

The architecture registry is updated to reflect the new llama.cpp commit. This ensures that the registry is in sync with the latest changes in the submodule and that the correct architecture information is used for model loading and execution.

"llama.cpp (hrx)": "40c4ccb76e48aafd44e024b0d2bb27b38bf54015"

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant