Чтение форм по умолчанию#632
Merged
Merged
Conversation
|
Warning Review limit reached
Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIntroduces a ChangesDefault Form Mapping Feature
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Test as Test/Client
participant FormOwner as MD Object (FormOwner)
participant Map as defaultFormMap
participant Forms as getForms()
Test->>FormOwner: getDefaultFormLink(DefaultFormKind.OBJECT_FORM)
FormOwner->>Map: lookup(kind)
Map-->>FormOwner: MdoReference or empty
FormOwner-->>Test: MdoReference
Test->>FormOwner: getDefaultForm(DefaultFormKind.OBJECT_FORM)
FormOwner->>Map: lookup(kind)
Map-->>FormOwner: link
FormOwner->>Forms: search by link
Forms-->>FormOwner: matching ObjectForm or none
FormOwner-->>Test: Optional<ObjectForm>
Estimated code review effort: 4 (Complex) | ~60 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Test Results 402 files ±0 402 suites ±0 8m 54s ⏱️ -24s Results for commit 48076d1. ± Comparison against base commit 8db75f0. This pull request removes 30 and adds 30 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/test/java/com/github/_1c_syntax/bsl/test_utils/MDTestUtils.java (1)
100-107: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick winOmit
defaultFormMapforExternalSourcetoo.ExternalDataProcessorandExternalReportimplementcom.github._1c_syntax.bsl.mdclasses.ExternalSource, notMD, so this guard skips them and their lazydefaultFormMapwill still end up in generated fixtures. Extend the omission toExternalSourceas well.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/test/java/com/github/_1c_syntax/bsl/test_utils/MDTestUtils.java` around lines 100 - 107, The fixture serialization in MDTestUtils currently omits lazy fields only for MD subclasses, so ExternalSource implementations like ExternalDataProcessor and ExternalReport still keep defaultFormMap. Update the omit-field logic in the existing XStream setup to also handle ExternalSource (using the same class-check block or an additional one) and ensure defaultFormMap is omitted for those classes as well.
🧹 Nitpick comments (5)
src/main/java/com/github/_1c_syntax/bsl/mdo/support/DefaultFormKind.java (1)
80-82: 🩺 Stability & Availability | 🔵 Trivial | 💤 Low valueNo null-guard in
valueByName.
string.toLowerCase(Locale.ROOT)will NPE ifstringisnull.EnumConverter.fromStringalready guards againstnullupstream, but sincevalueByNameis a public static API, other direct callers won't get that protection.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/github/_1c_syntax/bsl/mdo/support/DefaultFormKind.java` around lines 80 - 82, The public static DefaultFormKind.valueByName method currently dereferences string without a null check, so add a null-guard before calling toLowerCase(Locale.ROOT) and return null for null input. Keep the lookup logic in KEYS intact, and ensure any direct callers of valueByName are safe even when EnumConverter.fromString is not involved.src/main/java/com/github/_1c_syntax/bsl/mdclasses/ExternalDataProcessor.java (1)
137-152: 📐 Maintainability & Code Quality | 🔵 Trivial | 🏗️ Heavy liftRepeated
createDefaultFormMap()boilerplate across ~15 files.This identical pattern (fields + lazy map +
Map.ofEntrieshelper) is duplicated near-verbatim acrossExternalDataProcessor,ExternalReport,DocumentJournal,FilterCriterion,DataProcessor, theExternalDataSourceCube/Tablechildren,ChartOfCalculationTypes, and other register/chart types in this cohort. Consider extracting a shared static helper (e.g., onFormOwneror a utility class) that accepts varargsMap.Entry<DefaultFormKind, MdoReference>and builds the immutable map, to reduce copy-paste risk (as evidenced by the Settings/Variant form inconsistency flagged above).♻️ Example shared helper
// e.g. in FormOwner.java static Map<DefaultFormKind, MdoReference> buildDefaultFormMap(Map.Entry<DefaultFormKind, MdoReference>... entries) { return Map.ofEntries(entries); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/github/_1c_syntax/bsl/mdclasses/ExternalDataProcessor.java` around lines 137 - 152, The default-form map construction is duplicated across multiple form-owning classes, including ExternalDataProcessor and the related processors/reports/register types. Extract the repeated createDefaultFormMap pattern into a shared helper on FormOwner or a small utility method that accepts varargs of Map.Entry<DefaultFormKind, MdoReference> and returns the immutable map, then update each class’s defaultFormMap/createDefaultFormMap usage to call that helper instead of inlining Map.ofEntries. Make sure the shared helper preserves the same entry ordering and existing lazy field behavior.src/main/java/com/github/_1c_syntax/bsl/mdo/Catalog.java (1)
247-262: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚖️ Poor tradeoffRepeated
createDefaultFormMap()boilerplate across many MDO classes.The same
Map.ofEntries(...)wiring (differing only by whichDefaultFormKindentries apply) is duplicated verbatim across Catalog, ChartOfAccounts, ExchangePlan, ChartOfCalculationTypes, ChartOfCharacteristicTypes, BusinessProcess, register types, and ExternalDataSource children. This mirrors the existingcomputePossibleRights()duplication convention already in the codebase, so it's consistent with current practice rather than a new problem, but a shared varargs helper (e.g.FormOwnerSupport.buildDefaultFormMap(Map.entry(...), ...)) could reduce the copy-paste surface for futureDefaultFormKindadditions.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/github/_1c_syntax/bsl/mdo/Catalog.java` around lines 247 - 262, The repeated createDefaultFormMap() Map.ofEntries wiring in Catalog and the other MDO classes should be centralized to reduce copy-paste maintenance. Introduce a shared helper in the common form-owner support area (for example, a varargs builder that accepts Map.entry(DefaultFormKind, MdoReference) pairs) and update createDefaultFormMap() to delegate to it. Keep the per-class selection of DefaultFormKind entries intact, but remove the duplicated Map.ofEntries boilerplate from Catalog and the other affected MDO types.src/test/java/com/github/_1c_syntax/bsl/mdo/InformationRegisterTest.java (1)
41-84: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAsymmetric assertions and duplicated test bodies for
test/testSSL.
getDefaultFormMap()is asserted to have 4 entries (RECORD_FORM,LIST_FORM,AUX_RECORD_FORM,AUX_LIST_FORM), but neithertestnortestSSLassertsAUX_LIST_FORMlink/form, andLIST_FORM'sgetDefaultForm(...)result is never checked (onlygetDefaultFormLink). Also,test(lines 41-58) andtestSSL(lines 67-84) are near-identical bodies differing only in the@CsvSourcefixtures — consider merging them into a single@CsvSource-parameterized method (as done inAccountingRegisterTest/AccumulationRegisterTest).✅ Missing assertions to add
assertThat(ir.getDefaultFormLink(DefaultFormKind.LIST_FORM)).isEqualTo(MdoReference.EMPTY); + assertThat(ir.getDefaultForm(DefaultFormKind.LIST_FORM)).isEmpty(); + assertThat(ir.getDefaultFormLink(DefaultFormKind.AUX_LIST_FORM)).isEqualTo(MdoReference.EMPTY); + assertThat(ir.getDefaultForm(DefaultFormKind.AUX_LIST_FORM)).isEmpty();🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/test/java/com/github/_1c_syntax/bsl/mdo/InformationRegisterTest.java` around lines 41 - 84, The InformationRegisterTest methods are duplicating the same assertions and also missing coverage for the full default form map. Update the shared test body in test/testSSL (or merge them into one CsvSource-parameterized method like other register tests) and add assertions for AUX_LIST_FORM plus the missing getDefaultForm/getDefaultFormLink checks so all 4 expected entries from getDefaultFormMap are verified consistently.src/main/java/com/github/_1c_syntax/bsl/mdo/ChartOfCharacteristicTypes.java (1)
217-240: 📐 Maintainability & Code Quality | 🔵 Trivial | 🏗️ Heavy lift
createDefaultFormMap()body is duplicated verbatim across multiple classes.This exact 10-entry mapping (OBJECT_FORM/LIST_FORM/CHOICE_FORM/FOLDER_FORM/FOLDER_CHOICE_FORM + their AUX_ variants, built from identically-named getters) is repeated byte-for-byte in
Catalog,ChartOfAccounts, andChartOfCalculationTypes(per graph evidence). Since all four classes expose the same field names (defaultObjectForm,defaultListForm, etc.), this is a strong candidate for a shared default method (e.g. on a marker interface with these getters) instead of copy-pasting the map builder in every class. A similar pattern repeats for smaller 4-entry (Enum, registers,ExternalDataProcessor/ExternalReport) and 5-entry (Report,DataProcessor) variants.Given the number of files involved, this is a larger structural change; flagging once here as the representative case (see similar note on
Enum.javaandReport.java).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/github/_1c_syntax/bsl/mdo/ChartOfCharacteristicTypes.java` around lines 217 - 240, The createDefaultFormMap() implementation is duplicated across several MDO classes, so replace the repeated Map.ofEntries builder with a shared default method or helper on the common abstraction used by ChartOfCharacteristicTypes, Catalog, ChartOfAccounts, and ChartOfCalculationTypes. Preserve the existing DefaultFormKind-to-getter mapping, but centralize the logic using the identically named getters (getDefaultObjectForm, getDefaultListForm, getDefaultChoiceForm, getDefaultFolderForm, getDefaultFolderChoiceForm, and the AUX_* variants) so each class only supplies its form references. Apply the same consolidation pattern to the smaller Enum/registers/ExternalDataProcessor/ExternalReport and Report/DataProcessor variants where the same map-building code is repeated.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/com/github/_1c_syntax/bsl/mdclasses/ExternalDataProcessor.java`:
- Around line 100-152: Remove the report-only form kinds from
ExternalDataProcessor by updating the default form fields and mapping in
ExternalDataProcessor and createDefaultFormMap. Keep only the forms actually
exposed by this metadata object, and delete the defaultSettingsForm,
defaultVariantForm, auxiliarySettingsForm, and auxiliaryVariantForm references
from the schema and the DefaultFormKind map entries.
In `@src/main/java/com/github/_1c_syntax/bsl/mdo/AccountingRegister.java`:
- Around line 98-138: The createDefaultFormMap() implementation in
AccountingRegister duplicates the same two-entry Map.ofEntries logic used across
many MD classes. Extract this repeated mapping into a shared helper or default
method (for example on FormOwner or a small utility that accepts
DefaultFormKind/MdoReference entries), then update createDefaultFormMap() in
each affected class like AccountingRegister to delegate to that shared builder
while keeping only the class-specific getter calls.
---
Outside diff comments:
In `@src/test/java/com/github/_1c_syntax/bsl/test_utils/MDTestUtils.java`:
- Around line 100-107: The fixture serialization in MDTestUtils currently omits
lazy fields only for MD subclasses, so ExternalSource implementations like
ExternalDataProcessor and ExternalReport still keep defaultFormMap. Update the
omit-field logic in the existing XStream setup to also handle ExternalSource
(using the same class-check block or an additional one) and ensure
defaultFormMap is omitted for those classes as well.
---
Nitpick comments:
In
`@src/main/java/com/github/_1c_syntax/bsl/mdclasses/ExternalDataProcessor.java`:
- Around line 137-152: The default-form map construction is duplicated across
multiple form-owning classes, including ExternalDataProcessor and the related
processors/reports/register types. Extract the repeated createDefaultFormMap
pattern into a shared helper on FormOwner or a small utility method that accepts
varargs of Map.Entry<DefaultFormKind, MdoReference> and returns the immutable
map, then update each class’s defaultFormMap/createDefaultFormMap usage to call
that helper instead of inlining Map.ofEntries. Make sure the shared helper
preserves the same entry ordering and existing lazy field behavior.
In `@src/main/java/com/github/_1c_syntax/bsl/mdo/Catalog.java`:
- Around line 247-262: The repeated createDefaultFormMap() Map.ofEntries wiring
in Catalog and the other MDO classes should be centralized to reduce copy-paste
maintenance. Introduce a shared helper in the common form-owner support area
(for example, a varargs builder that accepts Map.entry(DefaultFormKind,
MdoReference) pairs) and update createDefaultFormMap() to delegate to it. Keep
the per-class selection of DefaultFormKind entries intact, but remove the
duplicated Map.ofEntries boilerplate from Catalog and the other affected MDO
types.
In `@src/main/java/com/github/_1c_syntax/bsl/mdo/ChartOfCharacteristicTypes.java`:
- Around line 217-240: The createDefaultFormMap() implementation is duplicated
across several MDO classes, so replace the repeated Map.ofEntries builder with a
shared default method or helper on the common abstraction used by
ChartOfCharacteristicTypes, Catalog, ChartOfAccounts, and
ChartOfCalculationTypes. Preserve the existing DefaultFormKind-to-getter
mapping, but centralize the logic using the identically named getters
(getDefaultObjectForm, getDefaultListForm, getDefaultChoiceForm,
getDefaultFolderForm, getDefaultFolderChoiceForm, and the AUX_* variants) so
each class only supplies its form references. Apply the same consolidation
pattern to the smaller Enum/registers/ExternalDataProcessor/ExternalReport and
Report/DataProcessor variants where the same map-building code is repeated.
In `@src/main/java/com/github/_1c_syntax/bsl/mdo/support/DefaultFormKind.java`:
- Around line 80-82: The public static DefaultFormKind.valueByName method
currently dereferences string without a null check, so add a null-guard before
calling toLowerCase(Locale.ROOT) and return null for null input. Keep the lookup
logic in KEYS intact, and ensure any direct callers of valueByName are safe even
when EnumConverter.fromString is not involved.
In `@src/test/java/com/github/_1c_syntax/bsl/mdo/InformationRegisterTest.java`:
- Around line 41-84: The InformationRegisterTest methods are duplicating the
same assertions and also missing coverage for the full default form map. Update
the shared test body in test/testSSL (or merge them into one
CsvSource-parameterized method like other register tests) and add assertions for
AUX_LIST_FORM plus the missing getDefaultForm/getDefaultFormLink checks so all 4
expected entries from getDefaultFormMap are verified consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 871d542e-70e0-4f40-9b33-55dc261feb61
⛔ Files ignored due to path filters (120)
src/test/resources/fixtures/external/ТестоваяВнешняяОбработка.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/external/ТестоваяВнешняяОбработка_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/external/ТестовыйВнешнийОтчет.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/external/ТестовыйВнешнийОтчет_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/AccountingRegisters.РегистрБухгалтерии1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/AccumulationRegisters.РегистрНакопления1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/BusinessProcesses.БизнесПроцесс1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/BusinessProcesses.БизнесПроцесс1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/CalculationRegisters.РегистрРасчета1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/CalculationRegisters.РегистрРасчета1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Catalogs.Справочник1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Catalogs.Справочник1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/ChartsOfAccounts.ПланСчетов1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/ChartsOfAccounts.ПланСчетов1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/ChartsOfCalculationTypes.ПланВидовРасчета1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/ChartsOfCharacteristicTypes.ПланВидовХарактеристик1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/ChartsOfCharacteristicTypes.ПланВидовХарактеристик1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/CommonAttributes.ОбщийРеквизит1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Configuration.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Configuration_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Constants.Константа1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Constants.Константа1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/DataProcessors.Обработка1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/DataProcessors.Обработка1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/DefinedTypes.ОпределяемыйТип1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/DocumentJournals.ЖурналДокументов1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/DocumentJournals.ЖурналДокументов1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Documents.Документ1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Documents.Документ1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Enums.Перечисление1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Enums.Перечисление1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/ExchangePlans.ПланОбмена1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/ExchangePlans.ПланОбмена1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/ExternalDataSources.ТекущаяСУБД.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/ExternalDataSources.ТекущаяСУБД_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/FilterCriteria.КритерийОтбора1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/FilterCriteria.КритерийОтбора1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/InformationRegisters.РегистрСведений1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/InformationRegisters.РегистрСведений1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Reports.Отчет1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Reports.Отчет1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Tasks.Задача1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses_3_18/Configuration.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses_3_18/Configuration_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses_3_24/Configuration_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses_3_25/CalculationRegisters.РегистрРасчета1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses_3_25/CalculationRegisters.РегистрРасчета1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses_3_27/ExternalDataSources.ВнешнийИсточникДанных1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses_3_27/ExternalDataSources.ВнешнийИсточникДанных1_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses_5_1/Configuration.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses_ext/Configuration.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses_ext/Configuration_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/BusinessProcesses.Задание.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/BusinessProcesses.Задание_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Catalogs.ВерсииФайлов.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Catalogs.ВерсииФайлов_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Catalogs.Заметки.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Catalogs.Заметки_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/ChartsOfCharacteristicTypes.ДополнительныеРеквизитыИСведения.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/ChartsOfCharacteristicTypes.ДополнительныеРеквизитыИСведения_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/CommonAttributes.ОбластьДанныхВспомогательныеДанные.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/CommonForms.Вопрос.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/CommonForms.Вопрос_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Constants.ЗаголовокСистемы.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/DataProcessors.ЗагрузкаКурсовВалют.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/DataProcessors.ЗагрузкаКурсовВалют_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/DocumentJournals.Взаимодействия.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/DocumentJournals.Взаимодействия_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Documents.Анкета.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Documents.Анкета_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Enums.СтатусыОбработчиковОбновления.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Enums.СтатусыОбработчиковОбновления_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/ExchangePlans.ОбновлениеИнформационнойБазы.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/ExchangePlans.ОбновлениеИнформационнойБазы_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/FilterCriteria.СвязанныеДокументы.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/FilterCriteria.СвязанныеДокументы_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/InformationRegisters.СклоненияПредставленийОбъектов.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/InformationRegisters.СклоненияПредставленийОбъектов_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/InformationRegisters.ЭлектронныеПодписи.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/InformationRegisters.ЭлектронныеПодписи_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Reports.АнализВерсийОбъектов.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Reports.АнализВерсийОбъектов_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/SettingsStorages.ХранилищеВариантовОтчетов.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/SettingsStorages.ХранилищеВариантовОтчетов_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Tasks.ЗадачаИсполнителя.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Tasks.ЗадачаИсполнителя_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/BusinessProcesses.Задание.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/BusinessProcesses.Задание_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Catalogs.ВерсииФайлов.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Catalogs.ВерсииФайлов_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Catalogs.Заметки.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Catalogs.Заметки_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/ChartsOfCharacteristicTypes.ДополнительныеРеквизитыИСведения.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/ChartsOfCharacteristicTypes.ДополнительныеРеквизитыИСведения_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/CommonAttributes.ОбластьДанныхВспомогательныеДанные.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/CommonForms.Вопрос.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/CommonForms.Вопрос_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Constants.ЗаголовокСистемы.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/DataProcessors.ЗагрузкаКурсовВалют.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/DataProcessors.ЗагрузкаКурсовВалют_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/DocumentJournals.Взаимодействия.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/DocumentJournals.Взаимодействия_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Documents.Анкета.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Documents.Анкета_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Enums.СтатусыОбработчиковОбновления.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Enums.СтатусыОбработчиковОбновления_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/ExchangePlans.ОбновлениеИнформационнойБазы.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/ExchangePlans.ОбновлениеИнформационнойБазы_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/FilterCriteria.СвязанныеДокументы.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/FilterCriteria.СвязанныеДокументы_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/InformationRegisters.СклоненияПредставленийОбъектов.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/InformationRegisters.СклоненияПредставленийОбъектов_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/InformationRegisters.ЭлектронныеПодписи.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/InformationRegisters.ЭлектронныеПодписи_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Reports.АнализВерсийОбъектов.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Reports.АнализВерсийОбъектов_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/SettingsStorages.ХранилищеВариантовОтчетов.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/SettingsStorages.ХранилищеВариантовОтчетов_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Tasks.ЗадачаИсполнителя.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Tasks.ЗадачаИсполнителя_edt.jsonis excluded by!src/test/resources/**
📒 Files selected for processing (43)
src/main/java/com/github/_1c_syntax/bsl/mdclasses/ExternalDataProcessor.javasrc/main/java/com/github/_1c_syntax/bsl/mdclasses/ExternalReport.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/AccountingRegister.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/AccumulationRegister.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/BusinessProcess.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/CalculationRegister.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/Catalog.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/ChartOfAccounts.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/ChartOfCalculationTypes.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/ChartOfCharacteristicTypes.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/DataProcessor.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/Document.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/DocumentJournal.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/Enum.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/ExchangePlan.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/FilterCriterion.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/FormOwner.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/InformationRegister.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/Report.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/SettingsStorage.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/Task.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/children/ExternalDataSourceCube.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/children/ExternalDataSourceCubeDimensionTable.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/children/ExternalDataSourceTable.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/support/DefaultFormKind.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/AccountingRegisterTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/AccumulationRegisterTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/BusinessProcessTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/CalculationRegisterTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/CatalogTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/ChartOfAccountsTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/ChartOfCalculationTypesTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/ChartOfCharacteristicTypesTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/DataProcessorTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/DocumentJournalTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/DocumentTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/EnumTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/ExchangePlanTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/FilterCriterionTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/InformationRegisterTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/ReportTest.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/SettingsStorageTest.javasrc/test/java/com/github/_1c_syntax/bsl/test_utils/MDTestUtils.java
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Связанные задачи
Closes: #19
Чеклист
Общие
gradlew precommit)Дополнительно
Summary by CodeRabbit
New Features
Bug Fixes