FIX: normalize git paths to POSIX so sidebar tree view works#201
Open
aletc1 wants to merge 1 commit into21st-dev:mainfrom
Open
FIX: normalize git paths to POSIX so sidebar tree view works#201aletc1 wants to merge 1 commit into21st-dev:mainfrom
aletc1 wants to merge 1 commit into21st-dev:mainfrom
Conversation
The sidebar files section rendered as a flat list on Windows because
paths occasionally contained backslashes, so the tree builder's
`path.split("/")` produced a single segment.
Normalize all paths emitted by the git status/diff parsers to forward
slashes at the single backend boundary. Git stores paths with "/" on
every platform, and Node fs / path.join accept "/" on Windows, so
downstream functionality (file reads, diffs, numstat lookups) is
unaffected. The renderer's many `split("/")` call sites keep working
unchanged on both platforms.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar files section rendered as a flat list on Windows because paths occasionally contained backslashes, so the tree builder's
path.split("/")produced a single segment.Normalize all paths emitted by the git status/diff parsers to forward slashes at the single backend boundary. Git stores paths with "/" on every platform, and Node fs / path.join accept "/" on Windows, so downstream functionality (file reads, diffs, numstat lookups) is unaffected. The renderer's many
split("/")call sites keep working unchanged on both platforms.