Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
There was a problem hiding this comment.
Code Review
This pull request adds a .deepsource.toml configuration file to enable DeepSource analyzers for C++ and Shell. Feedback suggests removing the unsupported [analyzers.meta] block for the shell analyzer to prevent schema validation errors, and narrowing down the test_patterns glob **/*test* to avoid misclassifying production assets as test code.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| [[analyzers]] | ||
| name = "shell" | ||
| enabled = true | ||
|
|
||
| [analyzers.meta] | ||
| dialect = "bash" |
There was a problem hiding this comment.
The DeepSource shell analyzer does not support any meta options (such as dialect). Specifying an invalid or unsupported meta option will cause a schema validation error in DeepSource, preventing the analysis from running.
ShellCheck (which powers the shell analyzer) automatically detects the shell dialect from the shebang line (e.g., #!/bin/bash in your scripts) or via inline directives. We should remove the [analyzers.meta] block for the shell analyzer.
| [[analyzers]] | |
| name = "shell" | |
| enabled = true | |
| [analyzers.meta] | |
| dialect = "bash" | |
| [[analyzers]] | |
| name = "shell" | |
| enabled = true |
| test_patterns = [ | ||
| "tests/**", | ||
| "test/**", | ||
| "**/*test*", | ||
| "**/*.test.*", | ||
| ] |
There was a problem hiding this comment.
The pattern **/*test* is extremely broad and will match any file or directory path containing the substring "test". In this repository, this matches production assets such as assets/bundled_skills/test-helper/skill.md.
This can cause DeepSource to misclassify production files/assets as test code, which applies different (often less strict) analysis rules. Consider removing **/*test* or replacing it with more specific patterns.
test_patterns = [
"tests/**",
"test/**",
"**/*.test.*",
]
Summary
Validation
.deepsource.tomlwith Pythontomllib.Follow-up
2233admin/CICADAin the DeepSource Dashboard after this PR merges.exclude_patternsif generated files dominate findings.