Skip to content

chore(#465): drop the last stale PowerShell mentions in live comments - #468

Merged
2233admin merged 1 commit into
mainfrom
chore/465-last-ps-mentions
Oct 19, 2026
Merged

2233admin merged 1 commit into
mainfrom
chore/465-last-ps-mentions

Conversation

@2233admin

Copy link
Copy Markdown
Owner

Final sweep for #465 after #467 and #466.

Comment-only. TOML parses, sentrux gate passes, repin clean.

Not changed: .sentrux/baseline.json still lists four deleted legacy/*.ps1 god files. It is owner-approved, so it is left for an intentional save_baseline (the gate already reports 30 -> 24 god files).

Closes #465.


Generated by Claude Code

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T12:02:39.676257Z 7f56997 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 69cf68db-2788-4645-b60c-371ed560ec09
📥 Commits

Reviewing files that changed from the base of the PR and between 8e29199 and 7f56997.

📒 Files selected for processing: 2
  • .sentrux/rules.toml
  • Run-ScopedRepowiseDocs.py
📝 Summary

Summary by CodeRabbit

  • Documentation
    • Clarified that PowerShell -and and -or are no longer counted as complexity terms.
    • Updated Anthropic fallback guidance to describe process-scoped environment variables provided by the caller.

Two comments now describe PowerShell operator counting and Anthropic fallback environment variables differently. No executable behavior changes.

Changes: Comment and documentation corrections

Layer / File(s) Summary
Corrected behavior descriptions
.sentrux/rules.toml, Run-ScopedRepowiseDocs.py
The rules comment says PowerShell’s -and and -or were counted until their removal in #465. The fallback comment says the caller sets process-scoped ANTHROPIC_API_KEY and ANTHROPIC_BASE_URL.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 7f569

These changes clarify existing behavior without showing a runtime regression. No actionable merge risk is established.

### Architecture Summary

Architecture risk: 🔵 Low · up to 7f569

The change affects 1 system.

Changed systems: Run-ScopedRepowiseDocs.py

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — Run-ScopedRepowiseDocs.py (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in Run-ScopedRepowiseDocs.py: The Anthropic fallback comment now describes the process-scoped variables as set by the caller; it no longer attributes their injection to the PowerShell wrapper or user-scoped CODE_INTEL_ANTHROPIC_* variables.
  • observed — Modified behavior in .sentrux/rules.toml: The comment now says PowerShell’s -and/-or were counted until #465 removed that behavior; the old comment said they were counted and bare English and/or were not.
Pre-merge checks: Passed 5
Check name Status Explanation
Description check Passed The description accurately explains both comment-only changes, their relation to issue #465, validation results, and the intentionally unchanged baseline.
Title check Passed The title clearly identifies the main change: removing stale PowerShell references from live comments for issue #465.
Linked Issues check Passed Issue #465 is directly linked. The reviewed head includes the earlier #467 code-and-contracts commit and #466 documentation commit in its history. This PR adds the final stale-reference cleanup: `.sen…
Out of Scope Changes check Passed The whole-PR diff contains only two comment or docstring updates. Both changes remove stale PowerShell references related to issue #465. No unrelated source, contract, baseline, or behavior changes ar…
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Full details: Linked Issues check

Explanation

Issue #465 is directly linked. The reviewed head includes the earlier #467 code-and-contracts commit and #466 documentation commit in its history. This PR adds the final stale-reference cleanup: .sentrux/rules.toml now describes PowerShell counting as historical, and Run-ScopedRepowiseDocs.py no longer attributes environment setup to a PowerShell wrapper. Historical decision text remains, as issue #465 permits.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff contains only two comment or docstring updates. Both changes remove stale PowerShell references related to issue #465. No unrelated source, contract, baseline, or behavior changes are present.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit reads the comments twice,
And finds the wording neat and right.
No scripts have changed their paths or ways,
Just clearer notes for future days.
Then hops away beneath the moon.

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Code Intel change risk

Score Percentile Level
47/100 22th (vs last 49 commits) 🟢 low

Top signals

  • Diff shape: 2 file(s), +3/-4 (max file share 0.57)
  • Test asymmetry: source changed, tests touched
  • Bug-magnet: 10 fix commit(s) in touched files (180d)
  • Churn: 15 commit(s) touching these files (90d)

revspec: origin/main..HEAD · threshold: score >= 80 blocks unless labeled risk-accepted; percentile is reported, not gated (#201) · code-intel change risk

@github-actions

Copy link
Copy Markdown

Code Intel Quality Signal

Completeness: complete · snapshot e9622fc016de · commit 7d2691653f46
Admission: pass · policy evidence-quality-admission v1 · aggregate regression: not_declined (advisory, not a blocking gate)

Total Baseline Delta
6750 6631 [OK] 119

Bottleneck: depth

Root cause Baseline Current Delta
modularity 0.29 n/a
acyclicity 0.0 n/a
depth 8.0 n/a
equality 0.47 n/a
redundancy 0.0 n/a

Findings (1 total)

Kind Severity Disposition Rule Message
root_cause_diagnostic medium advisory depth Quality Signal bottleneck: depth

@2233admin
2233admin merged commit 38483c2 into main Oct 19, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the remaining PowerShell: analysis support, leftovers and live docs (DR-0018 follow-up)

2 participants