Repository navigation
Keep truncated UTF-8 prefixes and skip ignored binaries before decode - #14
Merged
Merged
Conversation
A short tail such as b"a\xc3" stays "a" at any length. Ignored paths are excluded before those bytes are decoded. Vendor the JS parity fixture from cursor/main-green-utf8-915b at 034aa2f. Co-authored-by: ntc-ai <ntc-ai@users.noreply.github.com>
61e080, 61eda0, 61f080, and 61f490 stay binary. The decoder already rejects those second bytes, so the filter implementation is unchanged. Co-authored-by: ntc-ai <ntc-ai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
b"a\xc3"andb"a\xe0\xa0"decode to"a", including a tail past the 8192-byte probe). Illegal partials stay binary, including61e080,61eda0,61f080, and61f490.on_binary="include"still returns the original bytes.tests/fixtures/parity/relevance.jsonbyte-identical from 255BITS/patchlingcursor/main-green-utf8-915batf26c770a026f2554da3972c10b7f7918d075fd56. sha256dbe5c7033b279be2a0b923d82dffb1349039b051e18a3650b224570374b8914b.The hardcoded
tests/test_packaging.py::test_version_constant_is_0_8_1failure on v0.9.1 (51841f2, run 38342864453) is already fixed on main by v0.9.2 (43127320): packaging tests readpatchling.__version__instead of"0.8.1". This branch does not reintroduce a hardcoded version.PyPI to commit
Compared sdist and wheel package files from pypi.org with the tag trees (generated
PKG-INFO,*.dist-info, andpatchling.egg-infoignored). Each release matches its tag and not the parent or the neighboring releases. The only sdist-only file is a 38-byte setuptoolssetup.cfg(tag_build/tag_date) that is not in git.6077de5e5aaf9b1130b2e9960b6cefeb354893d3(tagv0.9.0)51841f2996ae6910bf6df160728b49533cba7dc4(tagv0.9.1)43127320f5f8e681910760a71d91e12ab8d67c30(annotated tagv0.9.2, tag object7671175c4bb7ab0b50d7dac5b9ac5f48ad2b8c21)Test plan
pytest -q testsoffline (171 passed, 2 skipped live tests).LIVE_LLMwas unset.2069eaf