refactor(protocol): prune grpc-gateway related proto#72
refactor(protocol): prune grpc-gateway related proto#72
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (22)
💤 Files with no reviewable changes (14)
📝 WalkthroughWalkthroughThis pull request removes Go package generation directives and HTTP/REST gateway annotations from proto files. The Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details
Summary by cubic
Removed
grpc-gatewaysupport from the protocol by stripping allgoogle.api.httpmappings andgo_packageoptions, and deleted unusedcore/tron/*protos. gRPC APIs stay the same; only REST bindings and Go codegen settings are removed.Refactors
google.api.httpannotations fromWallet,WalletSolidity,WalletExtension, andMonitor.option go_packagefrom API and contract protos.protocol/src/main/protos/core/tron/*.Migration
protoc-gen-gois no longer supported by these protos.Written for commit 04821b8. Summary will update on new commits.
Summary by CodeRabbit