Skip to content

feature(metrics): delete influxdb storage for metrics#73

Open
317787106 wants to merge 1 commit intodevelopfrom
feature/delete_influxdb
Open

feature(metrics): delete influxdb storage for metrics#73
317787106 wants to merge 1 commit intodevelopfrom
feature/delete_influxdb

Conversation

@317787106
Copy link
Copy Markdown
Owner

@317787106 317787106 commented Apr 17, 2026

What does this PR do?

  • delete influxdb storage for metrics

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details


Summary by cubic

Removed InfluxDB metrics storage and configuration across the codebase to simplify metrics handling. Prometheus metrics remain supported.

  • Refactors

    • Removed InfluxDB reporter/init paths from MetricsUtil and ApplicationImpl.
    • Deleted InfluxDB config keys and fields from CommonParameter, Args, ConfigKey, and config.conf.
    • Dropped Gradle dependency com.github.davidb:metrics-influxdb.
  • Migration

    • Remove node.metrics.storageEnable and all node.metrics.influxdb.* entries from config.conf (they are ignored).
    • Use Prometheus via node.metrics.prometheus.* for metrics scraping.

Written for commit de704e5. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Removed InfluxDB metrics storage functionality and related configuration options, including database connection parameters and reporting intervals.
    • Cleaned up unused dependencies and initialization code associated with InfluxDB metrics reporting.
    • Prometheus metrics support remains available.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8bdd95bf-b496-422d-87aa-dd857bab087e

📥 Commits

Reviewing files that changed from the base of the PR and between 2de63bb and de704e5.

📒 Files selected for processing (7)
  • common/src/main/java/org/tron/common/parameter/CommonParameter.java
  • framework/build.gradle
  • framework/src/main/java/org/tron/common/application/ApplicationImpl.java
  • framework/src/main/java/org/tron/core/config/args/Args.java
  • framework/src/main/java/org/tron/core/config/args/ConfigKey.java
  • framework/src/main/java/org/tron/core/metrics/MetricsUtil.java
  • framework/src/main/resources/config.conf
💤 Files with no reviewable changes (7)
  • framework/src/main/java/org/tron/common/application/ApplicationImpl.java
  • framework/src/main/resources/config.conf
  • framework/src/main/java/org/tron/core/config/args/Args.java
  • common/src/main/java/org/tron/common/parameter/CommonParameter.java
  • framework/src/main/java/org/tron/core/config/args/ConfigKey.java
  • framework/src/main/java/org/tron/core/metrics/MetricsUtil.java
  • framework/build.gradle

📝 Walkthrough

Walkthrough

The pull request removes InfluxDB metrics integration from the codebase by eliminating the metricsStorageEnable flag, InfluxDB configuration fields, the metrics-influxdb dependency, configuration keys, and initialization code across common parameters, configuration, and utility classes.

Changes

Cohort / File(s) Summary
Parameter Definitions
common/src/main/java/org/tron/common/parameter/CommonParameter.java
Removed metricsStorageEnable field and InfluxDB configuration fields (influxDbIp, influxDbPort, influxDbDatabase, metricsReportInterval) along with their generated getters/setters.
Configuration Keys
framework/src/main/java/org/tron/core/config/args/ConfigKey.java, framework/src/main/java/org/tron/core/config/args/Args.java
Removed InfluxDB-related configuration key constants and their config-file loading assignments for metrics storage and InfluxDB settings.
Metrics Initialization
framework/src/main/java/org/tron/core/metrics/MetricsUtil.java, framework/src/main/java/org/tron/common/application/ApplicationImpl.java
Removed MetricsUtil.init() method and all InfluxDB reporter setup code; removed the initialization call from application startup.
Build & Configuration Files
framework/build.gradle, framework/src/main/resources/config.conf
Removed metrics-influxdb dependency and InfluxDB-specific metrics configuration block including storageEnable and influxdb settings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A cleanup most fine, the InfluxDB line,
Is gone from the codebase, now lean and divine,
Prometheus remains to measure and tell,
But InfluxDB waves its goodbye farewell!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: removing InfluxDB storage functionality for metrics across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/delete_influxdb

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant