Repository navigation
fix(search): the dependency group appears when the feed lands after the query was typed - #925
Merged
Merged
Conversation
…he query was typed Live check of #919 in the founder's app (2026-10-11): with the query set in the same tick the field opened, "Your dependencies" stayed empty until the next keystroke. The provider is sync and reads the store's Preemption feed; opening the field starts that load, and results are only recomputed on input. A pasted query, or a slow first load, therefore missed the group. CommandSearch now re-runs the current query when `preemptionFeed` changes while the field is open and non-empty (the intelligence tier answers from its LRU cache, so no extra backend search). Test: CommandSearch.test.tsx stages "typed first, feed later" with a manually released get_preemption_alerts promise. It fails without the effect (group absent) and passes with it; a feed landing on an empty field adds no rows. Search suite 34/34, tsc and eslint clean. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CY6KandRe2fYACyoAHwRPe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #919, found during its live check in the founder's app.
Problem: if the query was set before the Preemption feed loaded, "Your dependencies" stayed empty until the next keystroke. That happens with a pasted query, or when the first feed load is slow. The provider is sync and reads the store's feed. Opening the field starts the load, but results only recompute on input.
Fix:
CommandSearchre-runs the current query whenpreemptionFeedchanges while the field is open and non-empty. The intelligence tier answers from its LRU cache, so this adds no extra backend search.Verified:
CommandSearch.test.tsxstages "typed first, feed later" with a manually releasedget_preemption_alerts. It fails without the effect and passes with it.tscandeslintare clean; the pre-push gate passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01CY6KandRe2fYACyoAHwRPe