Take the OWID library with the domain bound - #116
Merged
Conversation
The submodule pointed at a commit from before the domain bound was merged, so this repository carried neither that limit nor the payload size handling that went in with it. The OWID specification now makes the 253 character maximum a hard rule for creators as well as consumers, so a pointer left behind means the published code does not enforce what the specification requires. Moves owid-java from 7a7f3031 to 77619af4, which is that repository's main. No other change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
owid-javasubmodule from7a7f3031to77619af4, which is that repository'smainafter the domain bound was merged today.The OWID specification change makes the 253 character domain maximum a hard rule for creators as well as consumers, derived from RFC 1035. The seven language ports now enforce it on read and on write. Until this pointer moves, this repository ships against a library that does not.
Submodule pointer only, no other change. Whatever CI runs here is the check that it is safe.
Produced with AI assistance under James Rosewell's direction and needs human review.