feat(api): add feats endpoint and controller with tests#734
feat(api): add feats endpoint and controller with tests#734ToMakPo wants to merge 1 commit into5e-bits:mainfrom
Conversation
|
@ToMakPo Hey! I appreciate you taking the initiative on this. However, we'll need a PR in |
|
Hey. Yeah. I just pushed an update to the database. I added all the missing 2014 feats and all the 2024 feats. I think once those are pushed in, these changes should work. However, as I pointed out in that submission, updates to the structure of the feats class need to be made for both 2014 and 2024. I would need to dive deaper into how the code is set up to make sure I do it right. But with the changes I made in these two submissions, it should be a good starting point. |
What does this do?
This is the first time I've added to this repo. I started with something small. I went to every spot that had 2024 skills files and added feats. It looks like the skills files were taken straight from 2014 skills, so I did the same with feats. I also updated all references to 2014 to 2024. Please let me know if I am doing this right. Let me know if I should be doing something better.
How was it tested?
I ran
npm run test:unit. All tests passed. I then rannpm run test:integration:local. 5 of the 200+ tests failed. All 5 of them were tests trying to get data from /api/2024/feats (await request(app).get('/api/2024/feats')). I assume because they havent been added yet. I'm not sure.Is there a Github issue this is resolving?
No
Was any impacted documentation updated to reflect this change?
I have absolutely no idea. I'm not sure where to even look. I would guess not.
Here's a fun image for your troubles