Open
Conversation
Contributor
Author
|
Actually, #413 would be a nice extension to this |
Contributor
Author
|
@64bit My approach here still feels a bit like a hack. EventSource I feel is the real challenge here, perhaps replacing that or otherwise provides a more robust solution. For reference, I solved it in swiftide by hooking into the stream itself. This works really well, we use it in production at scale. A custom streaming backoff policy: https://github.com/bosun-ai/swiftide/blob/master/swiftide-core/src/stream_backoff.rs#L31 What are your thoughts on this? #428 seems to be gaining some traction. I haven't been able yet to get gpt5 to stream properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went into the rabbit hole of streaming backoffs. Turns out eventsource has something already, of which I'm not 100% certain how well it works, but since streaming is a bit different, we want to generally retry all the time. This PR sets the event source retry policy to the (similar) values of backoff. There's one slight difference in behaviour, in that on transport errors, we only retry server errors or 429s, like with regular requests.
We can't inspect the response body at this point, so we can't differentiate between rate limits and quota errors (thanks openai).
Also, during streaming, token errors are a rough 400. I think maybe. Sometimes.
Practically, I'm trying to stream a lot of agents in parallel, hoping with this I can mitigate it somewhat.