Skip to content

Only set IRC password in credentials if defined #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
silverbucket wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only set IRC password in credentials if defined #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/services/sockethub-irc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export default class SockethubIrcService extends Service {
sasl: account.server.sasl,
nick: account.nickname,
// username: account.username,
password: account.password
...(account.password && { password: account.password }),
Copy link
Member

@raucao raucao Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the property is undefined, then the password there would be set to undefined, i.e. not set. Or am I missing something?

}
});

Expand Down