fix: resolve grade 1 room view showing 0/0 by using overlapping check…#119
Open
redjungi09 wants to merge 1 commit intomainfrom
Open
fix: resolve grade 1 room view showing 0/0 by using overlapping check…#119redjungi09 wants to merge 1 commit intomainfrom
redjungi09 wants to merge 1 commit intomainfrom
Conversation
ehdus09
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#87
📝작업 내용
문제
1학년 학생이 출석 시
getOrCreateSchedule이 grade-specific 체크포인트("78교시", "9교시")로 schedule을 저장하는데, 선생님이 room 뷰 조회 시9교시")를 반환하여 schedule join 조건이 맞지 않아 1학년 학생이 전혀 조회되지 않는 문제 (0/0)getCurrentCheckpointOrNearest()가 grade-unaware하게 일반 체크포인트("8변경 사항
CheckpointResolvergetCurrentCheckpointOrNull(),getCurrentCheckpointOrNearest()에서 general 체크포인트(grade == null && dayOfWeek == null)만 사용하도록 변경AttendanceQueryRepositorycheckpoint.id.eq()→ 시간이 겹치는 체크포인트 ID 목록checkpoint.id.in()으로 변경9교시"(16:3018:59)와 시간이 겹치는 "78교시"(15:2017:19), "9교시"(17:20~18:10)도 조건에 포함되어 1학년 학생 정상 조회.distinct()추가💬리뷰 요구사항(선택)