Conversation
Co-authored-by: theg1239 <theg1239@users.noreply.github.com>
…n-e09c fix: avoid caching HTML in service worker
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile Summary
Confidence Score: 3/5The service worker caching direction is sound, but the cache-policy guard is not part of the normal validation path and the prefetch loop changes request pacing. The changed surface is small and focused, with a targeted standalone regression check, but the remaining issues can allow regressions to pass unnoticed and can alter runtime prefetch behavior. scripts/test-service-worker-cache-policy.mjs and public/sw.js
What T-Rex did
|
| await testHtmlNavigationIsNetworkOnly(); | ||
| await testHtmlNavigationKeepsOfflineFallback(); | ||
| await testNativePrefetchDoesNotPersistPages(); |
There was a problem hiding this comment.
This new regression test is not invoked by any package script or workflow, so it will not run during the normal build checks. A future change can reintroduce HTML caching or prefetch persistence while CI still passes. Please add a package script for this file and run it from the existing CI/build check path.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Artifacts
Repro: normal npm build validation output omits the service worker cache policy script
- Keeps the command output available without making the summary code-heavy.
Repro: CI-equivalent install and build attempt timed out during dependency installation
- Keeps the command output available without making the summary code-heavy.
Repro: standalone service worker cache policy script passes when invoked directly
- Keeps the command output available without making the summary code-heavy.
No description provided.