Skip to content

resync#464

Merged
theg1239 merged 2 commits into
devfrom
main
Jul 12, 2026
Merged

resync#464
theg1239 merged 2 commits into
devfrom
main

Conversation

@theg1239

@theg1239 theg1239 commented Jul 12, 2026

Copy link
Copy Markdown
Member

spent a lot of water and tokens to review your slop

Greptile Summary

This PR updates PDF buffer cache eviction to cancel unused downloads.

  • Adds a shared cache-entry eviction helper.
  • Aborts evicted downloads that have no listeners.
  • Uses the helper while trimming the cache.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues were found in the changed code. Entries with active listeners continue downloading, and deleting or aborting an already settled entry is harmless.

T-Rex T-Rex Logs

What T-Rex did

  • Reviewed the general-contract-validation-proof and examined pdf-cache-eviction-01-before.log to observe that the parent revision leaves an evicted listener-free preload running and fails the expected-abort assertion.
  • Validated the after-state by inspecting pdf-cache-eviction-02-after.log and confirming the head records exactly one abort for the oldest listener-free request and passes.
  • Verified the active-listener before/after captures show zero aborts, successful completion, progress notification, and safe unsubscribe.
  • Acknowledged that the reusable TypeScript harness and the parent-revision implementation snapshot are included to enable reproduction.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
lib/pdf/pdf-buffer-cache.ts Centralizes cache eviction and aborts listener-free downloads when they are evicted.

Reviews (1): Last reviewed commit: "Merge pull request #461 from ACM-VIT/cur..." | Re-trigger Greptile

cursoragent and others added 2 commits July 9, 2026 11:09
Co-authored-by: theg1239 <theg1239@users.noreply.github.com>
@vercel

vercel Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
examcooker-dev Error Error Jul 12, 2026 11:37am

@theg1239
theg1239 merged commit 60c3b9e into dev Jul 12, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants