Fix decoupled tests, refactor ICI parallelism override removal#3835
Open
gulsumgudukbay wants to merge 4 commits intoAI-Hypercomputer:mainfrom
Open
Fix decoupled tests, refactor ICI parallelism override removal#3835gulsumgudukbay wants to merge 4 commits intoAI-Hypercomputer:mainfrom
gulsumgudukbay wants to merge 4 commits intoAI-Hypercomputer:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix decoupled MaxText tests so they can run against the local decoupled test configuration without per-test ICI parallelism overrides.
Previously, many tests patched
ici_fsdp_parallelismdynamically through a shared test helper. This made decoupled behavior harder to reason about and spread device-count-specific setup across unrelated tests. This PR moves that behavior intodecoupled_base_test.ymlby inheriting frombase.ymland using config-level parallelism defaults (using @darisoy's changes in dbbc69e), then removes the ad-hoc helper from unit and integration tests.The follow-up ROCm-specific fixes keep unsupported ROCm paths isolated: parameter host offload is skipped on ROCm, ROCm GPU architecture strings are not parsed as CUDA compute capabilities, and packed Transformer Engine attention passes the THD metadata required by newer TE versions while preserving compatibility with older versions.
This keeps the upstream-facing behavior focused on decoupled/ROCm test correctness rather than changing general test configs.
Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.