Skip to content

Fix KeyError in MetricLogger when tensorboard is disabled.#3859

Open
copybara-service[bot] wants to merge 1 commit intomainfrom
test_912850668
Open

Fix KeyError in MetricLogger when tensorboard is disabled.#3859
copybara-service[bot] wants to merge 1 commit intomainfrom
test_912850668

Conversation

@copybara-service
Copy link
Copy Markdown
Contributor

@copybara-service copybara-service Bot commented May 9, 2026

Fix KeyError in MetricLogger when tensorboard is disabled.

Description

Fix KeyError in MetricLogger when enable_tensorboard=False.

Tests

Unit tests and Guitar integration.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/common/metric_logger.py 0.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@copybara-service copybara-service Bot force-pushed the test_912850668 branch 2 times, most recently from c7dfd0a to 6993e02 Compare May 9, 2026 07:43
@copybara-service copybara-service Bot changed the title Fix KeyError in MetricLogger when enable_tensorboard=False. Fix KeyError in MetricLogger when tensorboard is disabled. May 9, 2026
# Description

Fix KeyError in MetricLogger when enable_tensorboard=False.

# Tests

Unit tests and Guitar integration.

# Checklist

Before submitting this PR, please make sure (put X in square brackets):
- [X] I have performed a self-review of my code.
- [X] I have necessary comments in my code, particularly in hard-to-understand areas.
- [X] I have run end-to-end tests and provided workload links above if applicable.
- [X] I have made or will make corresponding changes to the doc if needed.

PiperOrigin-RevId: 912850668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant