fix(website): unblock CI on main (lockfile sync + skip gitignored DoD test)#89
Merged
Merged
Conversation
….9.3 The merge of #88 auto-resolved package-lock.json without re-running `npm install`, leaving a transitive `typescript@5.9.3` requirement unpinned in the lockfile. CI on main fails at the `npm ci` step: npm error Missing: typescript@5.9.3 from lock file npm error `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Regenerate via `npm install` on top of origin/main; only the lockfile changes (60 insertions, 1 deletion). `npm ci` succeeds end-to-end locally, npm test (1034/1034) and npm run build both green.
spMohanty
changed the title
The closing test in symmetry-explorer.accessibility-c50.test.mjs reads
`.aicrowd/v3/accessibility-checklist.md` to verify the DoD reference
stays intact. But `.aicrowd/` is gitignored (project rule: "specs
stay out of git"), so the file is present in local worktrees but
absent from fresh CI checkouts. The test was failing on main with:
ENOENT: no such file or directory, open '.../.aicrowd/v3/accessibility-checklist.md'
Make the test skip cleanly on CI (file absent) and continue running
locally (file present). The DoD assertion stays intact as a
local-dev guardrail; CI no longer fails on a gitignored fixture.
Implementation: `node:test`'s `{ skip: !checklistAvailable() }` form,
where `checklistAvailable()` is a tiny helper that returns false on
ENOENT. No copy or assertion changes; just gates the test on file
presence.
Verified locally: 1034/1034 (test still runs, file is present in the
worktree).
spMohanty
force-pushed
the
fix/website-package-lock-typescript-sync
branch
from
ed2b1d0 to
3b31546
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two follow-up fixes to unblock CI on main after #88 merged.
website/package-lock.json: the merge auto-resolved the lockfile without re-runningnpm install, leavingtypescript@5.9.3(transitive) unpinned.npm cifailed withMissing: typescript@5.9.3 from lock file..aicrowd/v3/accessibility-checklist.md, which is gitignored (per the standing "specs stay out of git" rule), so it ENOENT-fails on fresh CI checkouts. Now usesnode:test's{ skip: !checklistAvailable() }— runs locally where the file exists, skips on CI.Test plan
cd website && nvm use 23 && npm ciexits 0 (verified)npm test→ 1034/1034 (verified locally; CI will report 1033/1034 with one skip)npm run build→ green (verified)