Conversation
|
which tests are you referring to? |
|
Thanks I went over the noted lines and double checked it. Indeed it does pass at least a portion of the mentioned features except for I do need to update the table in general since I implemented all lines in the table it just looks silly that PHPantom just has a full row of green check marks, there are for sure still spots where it's still lacking or not doing thing 100% correctly (we still fail
Manually going over https://github.com/AJenbo/phpantom_lsp/blob/main/example.php and verifying that compleation / hover / definition works for the relevant lines in the demo section. |
|
P.s. @dantleech would you be interested in:
|
|
It's up to you. I'm not spending much time on Phactor currently.- there are lots of things whihc Phpactor doesn't support and that's fine. I've rsponded to the comments above. |
|
Cool. I just don't want to send it over if it's more of a burden then a help, I know what it's like to maintain OSS projects for free :) |
|
I updated the table to more accurately reflect LSP features rather then mostly focus on type engine support: https://github.com/AJenbo/phpantom_lsp?tab=readme-ov-file#features |
Hey, this project looks great but I notice that Phactor was flagged as not supporting some features which it actually should support..