Skip to content

Update Phactor capabilities#10

Merged
AJenbo merged 7 commits intoAJenbo:mainfrom
dantleech:patch-1
Mar 7, 2026
Merged

Update Phactor capabilities#10
AJenbo merged 7 commits intoAJenbo:mainfrom
dantleech:patch-1

Conversation

@dantleech
Copy link
Contributor

Hey, this project looks great but I notice that Phactor was flagged as not supporting some features which it actually should support..

@AJenbo AJenbo merged commit 9bd0a6f into AJenbo:main Mar 7, 2026
@dantleech
Copy link
Contributor Author

which tests are you referring to?

@AJenbo
Copy link
Owner

AJenbo commented Mar 7, 2026

Thanks I went over the noted lines and double checked it. Indeed it does pass at least a portion of the mentioned features except for yeild inside bodies.

I do need to update the table in general since I implemented all lines in the table it just looks silly that PHPantom just has a full row of green check marks, there are for sure still spots where it's still lacking or not doing thing 100% correctly (we still fail 23 11 PHPactor tests).

which tests are you referring to?

Manually going over https://github.com/AJenbo/phpantom_lsp/blob/main/example.php and verifying that compleation / hover / definition works for the relevant lines in the demo section.

@AJenbo
Copy link
Owner

AJenbo commented Mar 7, 2026

P.s. @dantleech would you be interested in:

  • A PR that bring over all PHPantom tests that PHPactor already passes (not already covered by your own tests)
  • A PR that bring over all PHPantom tests that PHPactor fails, marked as skip

@dantleech
Copy link
Contributor Author

dantleech commented Mar 7, 2026

It's up to you. I'm not spending much time on Phactor currently.- there are lots of things whihc Phpactor doesn't support and that's fine. I've rsponded to the comments above.

@AJenbo
Copy link
Owner

AJenbo commented Mar 7, 2026

Cool. I just don't want to send it over if it's more of a burden then a help, I know what it's like to maintain OSS projects for free :)

@AJenbo
Copy link
Owner

AJenbo commented Mar 12, 2026

I updated the table to more accurately reflect LSP features rather then mostly focus on type engine support: https://github.com/AJenbo/phpantom_lsp?tab=readme-ov-file#features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants