Repository navigation
CI: Ignore petab1to2 warning about a renamed experimentId column - #3494
Merged
Merged
Conversation
Since PEtab-dev/libpetab-python#572, `petab1to2` warns when it renames a v1 measurement table column `experimentId`, which is reserved in PEtab v2. With warnings as errors, this made the v1->v2 auto-upgrade, and thus the JAX benchmark tests for Brannmark_JBC2010 and Isensee_JCB2018, fail. The renamed column is not used for simulation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
marked this pull request as ready for review
October 26, 2026 19:09
dweindl
enabled auto-merge
October 26, 2026 19:09
FFroehlich
approved these changes
Oct 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3494 +/- ##
==========================================
+ Coverage 79.93% 79.97% +0.03%
==========================================
Files 331 331
Lines 23284 23284
Branches 1614 1614
==========================================
+ Hits 18613 18621 +8
+ Misses 4665 4657 -8
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PEtab-dev/libpetab-python#572,
petab1to2warns when it renames a v1 measurement table columnexperimentId, which is reserved in PEtab v2. With warnings as errors, the v1→v2 auto-upgrade fails, and so do the JAX benchmark tests for Brannmark_JBC2010 and Isensee_JCB2018 (e.g., https://github.com/AMICI-dev/AMICI/actions/runs/40377463587/job/121764332167). The renamed column is not used for simulation, so the warning is ignored.🤖 Generated with Claude Code