Open
Conversation
- DEPLOYMENT_GUIDE.md: Complete deployment instructions - TEST_REPORT.md: 75/75 tests passed (100%) - TESTNET_URLS.md: Public URLs and access info - MONITORING_SETUP.md: Monitoring configuration Closes #45
Contract Layer: - Add Asset enum (XLM, USDC) to config.rs - Add AssetPoolConfig for per-asset pool configuration - Update deposit.rs to use transfer_from (supports USDC approval flow) - Update withdraw.rs with error handling for token failures Storage Schema: - Per-asset pool configuration storage - Support for multiple assets (XLM + USDC) - Asset isolation (XLM proof can't withdraw USDC) Token Integration: - Stellar Asset Contract (SAC) integration for USDC - Token approval validation before deposit - Graceful error handling for token transfer failures Testing Notes: - USDC deposits require prior token approval - USDC withdrawals use try_transfer for safety - XLM flows remain unchanged - Cross-asset isolation maintained Closes #16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the privacy pool to support USDC deposits and withdrawals in addition to XLM.
Changes
config.rs
deposit.rs
withdraw.rs
Testing
Closes #16