loongson3: disable zero division check#89
Open
xry111 wants to merge 1 commit into
Open
Conversation
In other five architectures supported by AOSC, there are four without this check: arm64, loongarch64, ppc64, and riscv64. So it does not make too much sense to keep the historical behavior mimicking amd64 here.
xry111
force-pushed
the
mips-no-div-zero-check
branch
from
6879f99 to
da295b7
Compare
Member
|
Probably a good catch but we needed more compelling reasoning other than "all others do the same"... It also brings forth the question as to whether we should look into why this wasn't done on the upstream's end. |
Member
Contributor
Author
|
"All others do the same" explains why relying on SIGFPE to detect division by zero would not work in practice. OTOH, in C and C++ division by zero invokes undefined behavior so you cannot rely on the SIGFPE to detect division by zero even in theory, and in Rust division by zero panics so the inserted trap is simply never reachable. IMO at the very least the Rust part should be upstreamed. |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In other five architectures supported by AOSC, there are four without this check: arm64, loongarch64, ppc64, and riscv64.
So it does not make too much sense to keep the historical behavior mimicking amd64 here.