-
-
Notifications
You must be signed in to change notification settings - Fork 194
Add PDF Export for Debate Transcripts #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,6 @@ | ||
| .env | ||
| config.prod.yml | ||
| .DS_Store | ||
| server | ||
| main | ||
| *.exe |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,7 @@ func SetupTranscriptRoutes(router *gin.RouterGroup) { | |
| // Transcript CRUD operations | ||
| router.GET("/transcripts", controllers.GetUserTranscriptsHandler) | ||
| router.GET("/transcript/:id", controllers.GetTranscriptByIDHandler) | ||
| router.GET("/transcript/:id/export", controllers.ExportTranscriptPDFHandler) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Block export of pending transcripts, mate. The shown handler retrieves and renders any caller-owned transcript. It does not reject Reject non-completed transcripts in 🤖 Prompt for AI Agents |
||
| router.DELETE("/transcript/:id", controllers.DeleteTranscriptHandler) | ||
|
|
||
| // Utility endpoint to clean up pending transcripts | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift
Keep the export path read-only.
Line 253 calls
services.GetDebateTranscriptByID. That service writes an inferred result andupdatedAtwhenResult == "pending"inbackend/services/transcriptservice.go:801-849. A PDF download can therefore change transcript state and export a transcript that was not completed. Use a read-only ownership lookup for export, then reject pending transcripts separately, mate.🤖 Prompt for AI Agents